From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1B0302634E9; Thu, 16 Feb 2023 09:54:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1B0302634E9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1676530456; bh=hMxFYZkNXOik9+YIxT8x0SsRDpdRlSnOq+S+8pYc8gw=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VFSMTAQ5Fymq6hTd87Dbh+y6Opb30/iWpyiJGEZNuTLA2vJsTIagBj02K8vROEbrK NtESxEcocPsPHrV+vGZAxHHWKpWb/uz3Y4pYmPtrrPKdhPtTBq1PXDQP3I9bIgb+av nJnRKHwqjqCBrlmj6iA7ISMx5BgEtBFWHJ/46LTc= Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3FE1A21C253 for ; Thu, 16 Feb 2023 09:54:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3FE1A21C253 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1pSY9m-00059D-HK; Thu, 16 Feb 2023 09:54:14 +0300 Date: Thu, 16 Feb 2023 09:50:41 +0300 To: Maxim Kokryashkin Message-ID: References: <0f233a6e094d1552b0ac416ec1af4c87610f995f.1676413474.git.m.kokryashkin@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f233a6e094d1552b0ac416ec1af4c87610f995f.1676413474.git.m.kokryashkin@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9806C989EC2150E334A4A2EB925A9004F8F9CB1CA2AF71FC0182A05F538085040434792E3AB4D42145945566C30930FC315704D74D698E395D1B9887B9DF72CC9 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE782A779A89F7D69B2C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7FDE19FEC90BA7BD78F08D7030A58E5AD1A62830130A00468AEEEE3FBA3A834EE7353EFBB55337566CA35551357EC780ABDDC75C6BB5D930B7C617AE4D88CE141A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7FED1F8BA34440DC89FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3D0953842B444AAC3117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637B8F435DEDE9E76EBEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34F8A2DF183797A6A88AAA1250971841A16256AB9512A25A5E2D911F79531EC0CB948CB6681E75D9F21D7E09C32AA3244C47FD026851C4E775A5248EE753BC38B955E75C8D0ED9F6EEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojohRiI5imL4/wKCvdOA523Q== X-DA7885C5: BFE70994E0FA68912F8DD045696F5EA9B1C97215744B497E5B9D3BF3EA0C6C6C262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF5203AB6ACA73BA7E3066F1ED2DFB61F020FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 4/5] OSX: Disable unreliable assertion for external frame unwinding. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Maxim! Thanks for the patch! LGTM, except a few nits regarding the commit message. On 15.02.23, Maxim Kokryashkin wrote: > From: Mike Pall > > (cherry-picked from commit be251d9149b386ca0d4b51106be14366c5dbdf14) > > `_Unwind_Find_FDE()` will locate the FDE if the pc is in some > function that has an associated FDE. Note, Mac OS X 10.6 and > later, introduces "compact unwind info" which the runtime uses in > preference to DWARF unwind info. This function will only work if > the target function has an FDE but no compact unwind info. Please, mention that our VM has "compact unwind info" (see `BUILD_machasm` case), so this is the reason why DWARF unwind info isn't found by unwinder's `_Unwind_Find_FDE()`. Does it mean, that all `pcall()` related tests will fail on macOS with enabled external unwinder (this is why we don't need a test case)? > > Maxim Kokryashkin: > * added the description for the problem > > Part of tarantool/tarantool#7745 I suppose we should add: | Part of tarantool/tarantool#8069 > --- > src/lj_err.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/lj_err.c b/src/lj_err.c > index f6200233..975b5621 100644 > --- a/src/lj_err.c > +++ b/src/lj_err.c > -- > 2.39.0 > -- Best regards, Sergey Kaplun