From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A70202B2965; Mon, 27 Feb 2023 12:54:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A70202B2965 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1677491690; bh=6CuRm0ma5mxN7yPSzLrHFmyHWyQCSNbscjmj/48+HnU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=oCO9sdpQlXTUbqIDVlxJkKJqAXUPxsXfY15KWvJA3eu10GIYws534L5IKQYOL+OY+ XL8dzvaNeBSuugA/CRXFqHvAcHw3adrn/HJqf1ZLiIQEX+cMs33HXKDIljIwJP21mn Yl7OYc4VVF3hyv9eZgJ8y6lITRrbpBCd6qXiqTfw= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 46D3921C253 for ; Mon, 27 Feb 2023 12:54:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 46D3921C253 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1pWaDY-0001Tl-HJ; Mon, 27 Feb 2023 12:54:48 +0300 Date: Mon, 27 Feb 2023 12:51:11 +0300 To: Igor Munkin Message-ID: References: <2b510bb3d602fb66b7ee0310ca027f9e8be66480.1677236706.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2b510bb3d602fb66b7ee0310ca027f9e8be66480.1677236706.git.imun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD94A31EA4B0797EF2EE50B5111BED4E5A0F9C3BE6961C3C823182A05F5380850404C228DA9ACA6FE2738992314E9C3ED4209FA4762DCB15866FD6CF4EA40563FFB35A996DF8C996D42 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637DDCE02C19EA0BA868638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8688B3288C358A54D4A19FBA3675242B9117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA1C5B227563B4AFA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520CCD848CCB6FE560C6FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B69DC5D3EDC80DC730089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349C39CCCDAABCB54B90630F97E265D0EB76CFBE4C404B5EC8AF7B6AED6F9736B631ED7734ED8065DA1D7E09C32AA3244C2943EEACA0CB3832071D49DE4626683DB4DF56057A86259FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojY+HhiuGRi+pGDyUh6LyUDQ== X-DA7885C5: 5F3B1C3344A24FF0BA0AF385F441F4187EB52B59785CA66CB84E0FB3CEA88FAC262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF5D9E49F55148AEE62A8EC57746549D5C80FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/5] test: introduce test:skipall TAP helper X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, just a few nits regarding the commit message. On 27.02.23, Igor Munkin wrote: > Sometimes one need to skip all tests in the script. TAP13 protocol Typo: s/need/needs/ > supports this via the following line: > | 1..0 # SKIP > > Within this commit helper is introduced that yields the > aforementined line to the TAP consumer and exits the test script. It's Typo: s/aforementined/aforementioned/ > worth to mention, that skipall helper is implemented only for root (i.e. > test with no parent) tests and subtests are not supported at the moment. > The corresponding assertion with FIXME reason is added to . > > Signed-off-by: Igor Munkin > --- > test/tarantool-tests/tap.lua | 23 ++++++++++++++++++++--- > 1 file changed, 20 insertions(+), 3 deletions(-) > > diff --git a/test/tarantool-tests/tap.lua b/test/tarantool-tests/tap.lua > index a1f54d20..92d59ce9 100644 > --- a/test/tarantool-tests/tap.lua > +++ b/test/tarantool-tests/tap.lua -- Best regards, Sergey Kaplun