From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounces@dev.tarantool.org>
Received: from [87.239.111.99] (localhost [127.0.0.1])
	by dev.tarantool.org (Postfix) with ESMTP id AB7FF21C253;
	Mon, 27 Feb 2023 12:32:01 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AB7FF21C253
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev;
	t=1677490321; bh=29MqPK42sVo/6LuBnlwmY/zgb4Fioj8wpStMHVaDbkI=;
	h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:
	 List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:
	 From;
	b=lA4M/ZHkbW8x2UHqNyh5iijcm7VW+Jhfm9Uoxnp5aQq5hMZE7yFfSGErQyesgWwYy
	 g+PVj7q6gb28Ns0+H/o3jX5P6jc4nHwikWdyNJyPTv7f/suor5IjGeRG9d1QKDxXNQ
	 7f87Jdj46bXWqoBymIwtYoAsQon4Y2dci26oOLIc=
Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2F1EC21C253
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 27 Feb 2023 12:32:00 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2F1EC21C253
Received: by smtpng1.m.smailru.net with esmtpa (envelope-from
 <skaplun@tarantool.org>)
 id 1pWZrT-0002Hw-AD; Mon, 27 Feb 2023 12:31:59 +0300
Date: Mon, 27 Feb 2023 12:28:22 +0300
To: Igor Munkin <imun@tarantool.org>
Message-ID: <Y/x3tuxg2r3I66oG@root>
References: <cover.1676304797.git.imun@tarantool.org>
 <73073fb24db65f59c8629f4f377faa9e52cb54af.1676304797.git.imun@tarantool.org>
 <Y+yS8G8R7TjL1jmn@root> <Y/x02OESbcewHWew@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Y/x02OESbcewHWew@tarantool.org>
X-Mailru-Src: smtp
X-4EC0790: 10
X-7564579A: B8F34718100C35BD
X-77F55803: 4F1203BC0FB41BD9806C989EC2150E3306C371BD2459F3C9654D0ADB2016EE03182A05F53808504070C591832DA3CFF0B1E8D75FE3309237DD6F413B84A21E8BA633A1DABE91B660
X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E2331B2371EFE129EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637995C329E4A8C93938638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84E0905DA62B2BADB74C1EB55DBEF69DC117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCE287FC2BA681BAD5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735204B6963042765DA4BCB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6C94F115956DE4A7A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF
X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34E318F287A436F24CF3AB167DE367DC2DCD10190D247C7C2758F05A4BB82039E09900762CE1974CF81D7E09C32AA3244C5274A751F2C18760E5564A3C12CCB6D7725D5B54B2FE4575FACE5A9C96DEB163
X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojY+HhiuGRi+pIZdkYOAet3A==
X-DA7885C5: 09F26AE89440800770A2210A95F639714CE85A9B01B073FE45CD945DC92454FA262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71
X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF56D5F71E891397A10B53F3D31861E313D0FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675
X-Mras: Ok
Subject: Re: [Tarantool-patches] [PATCH luajit 3/7] test: stop using
 utils.selfrun in tests
X-BeenThere: tarantool-patches@dev.tarantool.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
Reply-To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Errors-To: tarantool-patches-bounces@dev.tarantool.org
Sender: "Tarantool-patches" <tarantool-patches-bounces@dev.tarantool.org>

Hi, Igor!
Thanks for the fixes!

LGTM, just a minor nit below!

On 27.02.23, Igor Munkin wrote:
> Sergey,
> 
> Thanks for your review! See my answers below.
> 

<snipped>

> > 
> > > +    REDIRECT = opts and opts.redirect or '',
> > > +  }, {
> > > +    __call = function(self, ...)
> > > +      local cmd = ('<ENV> <LUABIN> <REDIRECT> <SCRIPT>'):gsub('%<(%w+)>', self)
> > > +                  .. (' %s'):rep(select('#', ...)):format(...)
> > 
> > It's good to comment that we just format arguments to strings for the
> > script invocaiton.
> 
> Well, yeah... my Perl background is coming out ;)
> 
> Anyway, here is the comment:
> 
> ================================================================================
> 
> diff --git a/test/tarantool-tests/tap.lua b/test/tarantool-tests/tap.lua
> index ac04c01d..f5e08043 100644
> --- a/test/tarantool-tests/tap.lua
> +++ b/test/tarantool-tests/tap.lua
> @@ -60,8 +65,17 @@ function M.makecmd(arg, opts)
>      REDIRECT = opts and opts.redirect or '',
>    }, {
>      __call = function(self, ...)
> +      -- This line just makes the command for <io.popen> by the
> +      -- following steps:
> +      -- 1. Replace the placeholders with the corresponding values
> +      --    given to the command constructor (e.g. script, env)
> +      -- 2. Join all CLI arguments given to the __call metamethod
> +      -- 3. Concatenate the results of step 1 and step 2 to obtain
> +      --    the resulting command.

Extra dot in the end of the list (or missing in the previous bullets).

>        local cmd = ('<ENV> <LUABIN> <REDIRECT> <SCRIPT>'):gsub('%<(%w+)>', self)
>                    .. (' %s'):rep(select('#', ...)):format(...)
> +      -- Trim both leading and trailing whitespace from the output
> +      -- produced by the child process.
>        return io.popen(cmd):read('*all'):gsub('^%s+', ''):gsub('%s+$', '')
>      end
>    })
> 
> ================================================================================
> 
> > 
> > > +      return io.popen(cmd):read('*all'):gsub('^%s+', ''):gsub('%s+$', '')
> > > +    end
> > > +  })
> > >  end
> > >  
> > >  function M.skipcond(condition, message)
> > > -- 
> > > 2.30.2
> > > 
> > 
> > -- 
> > Best regards,
> > Sergey Kaplun
> 
> -- 
> Best regards,
> IM

-- 
Best regards,
Sergey Kaplun