From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1D89021C253; Mon, 27 Feb 2023 12:18:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1D89021C253 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1677489497; bh=NHGM1a+lZttbSH3lRwg2zqdM3CPKijf1tOntRQOlXds=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NRsFxWHBZiHh2iH5pRp78nvgyP3e7dpXrBxR658GwEvWh+YGjyC7r+Ir2EWUdeBZi ye7/aPew/MPInMHV+EieBPQSLOvTaUms8u+EqsMUnRxISLFcc4zWqnvkKkHrNYSmCS m2iVtNykFYIL+iuw2jShzMmXRmYHdbSVDxgIKWX8= Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [95.163.41.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 15C5F21C253 for ; Mon, 27 Feb 2023 12:18:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 15C5F21C253 Received: by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1pWZeA-0069uT-0j; Mon, 27 Feb 2023 12:18:14 +0300 Date: Mon, 27 Feb 2023 09:15:34 +0000 To: Sergey Kaplun Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9806C989EC2150E332707AF5C8463FB27632E61488AC5AD3D182A05F538085040213ECEC51B7C9F34F9DA2E5476DC982EEF3476431A6D33DC4CEB51588C4357FC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7850A3F981F25E362EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063764345650F0BBEB0B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D82419D1E96D84B8DC4CDE225D6C6A166C117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC406C66621D3021AFA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520C65AC60A1F0286FEC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE042285CD7A5C321F7C6FCE95544A9834D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3F8BD4E506CFA3D886136E347CC761E07C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006371F24DFF1B2961425731C566533BA786AA5CC5B56E945C8DA X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B3611847B8BC2D0B9AFF04777F23C803032B56430AFFE7B794561379585BAB502F14C6E6FD5CEC431D7E09C32AA3244C7DC460CA725839202CF1B3E1D124E2B81E098CBE561D6343927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojY+HhiuGRi+pWZnb0tTN64A== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531569EBBEE27F445522B0AC6718651686D939C948A0ED64AC72326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/7] build: fix build with JIT disabled X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 13.02.23, Sergey Kaplun wrote: > Hi, Igor! > Thanks for the patch! > LGTM, except a single nit regarding the commit message. > > On 13.02.23, Igor Munkin wrote: > > struct GCtrace is defined only if LJ_HASJIT is set. Hence all spots > > Typo: s/Hence,/Hence/ Fixed, force-pushed. > > > where GCtrace is used should be also moved under LJ_HASJIT define. > > > > Relates to tarantool/tarantool#8252 > > Side note: I see "Relates" and "Related" in our commit logs, so I > suggest to use "Relates" for future commits. I always use "Relates" (except maybe some early commits). > > > > > Signed-off-by: Igor Munkin > > > > > -- > > 2.30.2 > > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM