From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D0F782ADDFA; Mon, 27 Feb 2023 12:19:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D0F782ADDFA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1677489560; bh=pHZNT5fMF1LN9tuo+VztzUL886ENamkqpvVSVt2Yk0Y=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MhK7YXc2k64DOQRu0BbhFUbZ5t9Am+4+3AIXFoijxYOjShaWq4+lrqroERyZZfltZ VsbcVwHXA0zHvoTRr/CkUCBny+q5Tj39Rb72t+Kstxy+3OAuc1PS/yiC388a6TS1H/ Ta3coTMVwkEPUqkGHuW9a7W+pXMxrSno4aXemyi8= Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [95.163.41.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A2A4D2ADDF4 for ; Mon, 27 Feb 2023 12:19:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A2A4D2ADDF4 Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1pWZez-002C1W-QN; Mon, 27 Feb 2023 12:19:06 +0300 Date: Mon, 27 Feb 2023 09:16:26 +0000 To: Maxim Kokryashkin Message-ID: References: <73073fb24db65f59c8629f4f377faa9e52cb54af.1676304797.git.imun@tarantool.org> <1676497395.939233553@f714.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1676497395.939233553@f714.i.mail.ru> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9806C989EC2150E33F4358D0D08B70F42B7087717838FB7B6182A05F5380850404AC8B967F782FCF3FF01D13B302CF4C32495E71BADBA63DE707573D0E22F42FB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7C579B1C3ABE6C709C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7C42AF033AFE07300EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B6F1F7B995052D5CE94C6A306024B3B0953B09C4B18BFA666CC7F00164DA146DAFE8445B8C89999728AA50765F79006370A32D918A17158F1389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B6FBD635917D924DF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF3F7A3D03CB1379C6E0066C2D8992A164AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C3D8561A2FEC730ACEBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7D151390FFDBF6399731C566533BA786AA5CC5B56E945C8DA X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34197948450CB5442A371D76934C7A61BC3FC6EDECA8318E17CF7C5F33EA5C5335879D2BC65EDCB5511D7E09C32AA3244C3250C77494CBE6A8FE698DA0ADEDD77A69B6CAE0477E908D927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojY+HhiuGRi+pm9xtbNLJXIw== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531569EBBEE27F4455261EF5A941672F332CD2FF55889A614832326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/7] test: stop using utils.selfrun in tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for your review! See my answers below. On 16.02.23, Maxim Kokryashkin wrote: > > Hi, Igor! > LGTM, except for a few nits below. >   > >>diff --git a/test/tarantool-tests/gh-4427-ffi-sandwich.test.lua b/test/tarantool-tests/gh-4427-ffi-sandwich.test.lua > >>index dd02130c..f4795db0 100644 > >>--- a/test/tarantool-tests/gh-4427-ffi-sandwich.test.lua > >>+++ b/test/tarantool-tests/gh-4427-ffi-sandwich.test.lua > >>@@ -3,52 +3,43 @@ local utils = require('utils') > > > >>+ -- TODO: Leave another toxic comment regarding SIP on macOS. > >That comment is unnecessary. Here and below. ================================================================================ diff --git a/test/tarantool-tests/gh-4427-ffi-sandwich.test.lua b/test/tarantool-tests/gh-4427-ffi-sandwich.test.lua index ff3eaf01..ad06c329 100644 --- a/test/tarantool-tests/gh-4427-ffi-sandwich.test.lua +++ b/test/tarantool-tests/gh-4427-ffi-sandwich.test.lua @@ -6,8 +6,23 @@ local test = tap.test('gh-4427-ffi-sandwich'):skipcond({ test:plan(2) +-- runs %testname%/script.lua by +-- with the given environment, launch options and CLI arguments. local script = require('utils').makecmd(arg, { - -- TODO: Leave another toxic comment regarding SIP on macOS. + -- XXX: Apple tries their best to "protect their users from + -- malware". As a result SIP (see the link[1] below) has been + -- designed and released. Now, Apple developers are so + -- protected, that they can load nothing being not installed in + -- the system, since the environment is sanitized before the + -- child process is launched. In particular, environment + -- variables starting with DYLD_ and LD_ are unset for child + -- process. For more info, see the docs[2] below. + -- + -- The environment variable below is used by FFI machinery to + -- find the proper shared library. + -- + -- [1]: https://support.apple.com/en-us/HT204899 + -- [2]: https://developer.apple.com/library/archive/documentation/Security/Conceptual/System_Integrity_Protection_Guide/RuntimeProtections/RuntimeProtections.html env = { DYLD_LIBRARY_PATH = os.getenv('DYLD_LIBRARY_PATH') }, redirect = '2>&1', }) ================================================================================ > >  > > > >> > >>diff --git a/test/tarantool-tests/utils.lua b/test/tarantool-tests/utils.lua > >>index eb11d40d..41a7c22a 100644 > >>--- a/test/tarantool-tests/utils.lua > >>+++ b/test/tarantool-tests/utils.lua > >>+ }, { > >>+ __call = function(self, ...) > >>+ local cmd = ('