From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 91AE62B296B; Mon, 27 Feb 2023 12:59:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 91AE62B296B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1677491993; bh=KJZm2I6tcRhbgIq/g5tzvOaCAurr7e1IX7scrnUOcvU=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LEGOdPi+UeJ1iuYQvnRfFOgcQaW3NOEtNZ4ANar5FIxZ0V9ziLIz4S27h1s0pUYpz nHgS8ZThUYvOYlgGms7acDEQat1xA/MGI0OI41NX1QJS1CaNvUcjO1ehnGGcp1Hb3v MJWlN4IV38ZZEYEBBnh4sX4dCW4vFcLhQs4X7dTI= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 75D6021C253 for ; Mon, 27 Feb 2023 12:59:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 75D6021C253 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1pWaIR-0003p0-PS; Mon, 27 Feb 2023 12:59:52 +0300 Date: Mon, 27 Feb 2023 12:56:15 +0300 To: Igor Munkin Message-ID: References: <73121e49f78fb8fee355ce09a80f77ef12046e67.1677236706.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73121e49f78fb8fee355ce09a80f77ef12046e67.1677236706.git.imun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9806C989EC2150E3306C371BD2459F3C96D6C2FD6C17EDBFE182A05F538085040409C0C13D84DAA10D3308D174E3B3EFA7094629C7A0A2C51FF48A3EEB6F3B579 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE716FAD50E497B9C14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372BE3E2E75E3847F48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D85EA33CA0E826CBDA41753971D3F3CA3B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCC2ED6D5310B1F811A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520CCD848CCB6FE560CBDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B69DC5D3EDC80DC730089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34738A88CA0C70A55843BBC3917961A0705ACB3F6F5E706BFF4D002E9C03DA868D6DFC9EE2B85FA2541D7E09C32AA3244C863161E417AA60B9B2730BD23CDCCC27FE8DA44ABE2443F7FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojY+HhiuGRi+oyniyzW0Yb1g== X-DA7885C5: 226B674E27F350704B128D57E830D7A2E0D11B375BBD7E05EE3E1BD7AB7A1334262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73933AF1F914F131DBF5B4460A8AD33AC42EBD9A12AE49C0D6C00FBE9A32752B8C9C2AA642CC12EC09F1FB559BB5D741EB962F61BD320559CF1EFD657A8799238ED55FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 4/5] test: introduce test:skiprest TAP helper X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, except a single nit regarding the commit message. On 27.02.23, Igor Munkin wrote: > Sometimes one need to skip the remaining tests in the script. There is Typo: s/need/needs/ > no special stub in TAP13 protocol for this, but this could be done via > skipping all the remaining planned tests. > > Within this commit helper is introduced that calls > (planned - total) times and exits the test script. As for > the previous commit it's worth to mention, that skiprest helper is > implemented only for root (i.e. test with no parent) tests and subtests > are not supported at the moment. The corresponding assertion with FIXME > reason can be found in routine. > > Signed-off-by: Igor Munkin -- Best regards, Sergey Kaplun