From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 69D243048E4; Tue, 28 Feb 2023 22:07:13 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 69D243048E4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1677611233; bh=nQB9xEUZ87x5XBoGU7ztV/L1gjeGg3NVlHmq9BZKgns=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=zruF+FTaM+SRE+XWvWXIjW64tZ/BMZh4E9Jrm0+SKiuxc3FqntqmPh3tTiuweWOhb 5zf2kcUqDFDIfyu9UJ4Sw94onWYWMDY6WU9K94e0UfONU4OtKGpqf8cVYHJnKFO8Nm zmVcw5ifdPQK+jK713/LXDvJ/whxxhMKGSe+npAg= Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [95.163.41.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 86A8E3048D3 for ; Tue, 28 Feb 2023 22:05:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 86A8E3048D3 Received: by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1pX5Hc-004lu5-G2; Tue, 28 Feb 2023 22:05:04 +0300 Date: Tue, 28 Feb 2023 19:02:12 +0000 To: Maxim Kokryashkin Message-ID: References: <1676500298.80185435@f308.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1676500298.80185435@f308.i.mail.ru> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9CCAB0EF48C080D70105573A450DCCFFB6B387E0C50F395B0182A05F538085040077094DC902F97639B3D456BA4116C6018696F5961687625BEFB60DD9904AF9B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77FAFB841CE9024F9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F5B2F26146BDF5648638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A1BAB39E19910115FDEE50283DB9703F117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC6D77D8F98F67F34EA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520599709FD55CB46A6E5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EEFAD5A440E159F97D9F804269016115C9D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3F8BD4E506CFA3D886136E347CC761E07C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637A7EFCB0EB5ACB161EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34EE19B6E2433CA093302B4CAAF28E42B982AB0162BEB28411416A183C8B24BDEC2D268A5C8957A8951D7E09C32AA3244CD0FCC85DAC9970E41A482266F998AC0197FE24653F78E668927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMN6DA1mNzI/twA9wlj2wXg== X-Mailru-Sender: 2FEBA92C8E508479FE7B9A1DF348D531FBFE2EABCEB21FC300E86A3B2C302D94A96F51CF8A3FC7502326FE6F2A341ACE0FB9F97486540B4CD9E8847AB8CFED4D9ABF8A61C016C2CFB0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 5/7] test: add skipcond for all JIT-related tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, Thanks for your review! I've fixed the comments you've left. On 16.02.23, Maxim Kokryashkin wrote: > > Hi, Igor! > Thanks for the patch! > Please consider my comments below. >   > `lj-906-fix-err-mem.test.lua` has a `jit.off()` > call in the line 78, which should be wrapped in a pcall. Hm, thanks for noticing! Fun fact: jit.off doesn't raise the error when JIT is not compiled. I guess we can left pcall only for jit.flush calls. >   > This change should be moved to commit > «build: fix build with JIT disabled» > (a835fb0f778db6e9f0109a66ea1d2ac78fe682e4) > along with the change that I pointed out below. As we discussed offline, these changes should be left here. Ignoring. > >  > -- > Best regards, > Maxim Kokryashkin >   -- Best regards, IM