From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 976246EC60; Mon, 29 Mar 2021 19:01:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 976246EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617033669; bh=55jCdM1o/Ob4f0oQRt1Ei5T9JLF10BUVhuppRW4s8aQ=; h=Date:In-Reply-To:To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Opw+YS/scy61URVD4WmPfX6BXQsv7W9dIUvyMPkyLZRf/moygyFcj74OUZlpV2RHX 5j3yBDzDmBxg/ggwSWYkOvYox3zfsIytMMnJ8qm0rXUO6mKk2kZkLyoAgK0qAMr2u3 OHrFgt4DIHxz94rJ9CEEOkqzHQYG75HL1aC4ysMQ= Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 29CFC6EC60 for ; Mon, 29 Mar 2021 19:01:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 29CFC6EC60 Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1lQuKB-0004oy-9u; Mon, 29 Mar 2021 19:01:07 +0300 Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_837D974B-B20F-475F-91B3-1F73A5173F17" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Date: Mon, 29 Mar 2021 19:01:06 +0300 In-Reply-To: <20210329083559.GL29703@tarantool.org> To: Igor Munkin References: <20210309175422.25432-1-skaplun@tarantool.org> <20210325201459.GG29703@tarantool.org> <20210326101035.GH29703@tarantool.org> <20210326183856.GI29703@tarantool.org> <20210329083202.GK29703@tarantool.org> <20210329083559.GL29703@tarantool.org> X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294CA3588DDE0233B0D17711AF1EA2D7DB9182A05F538085040C7B451530554DA4562097CEBE7D72A45D144EFE5EBA7C94D6D063CA1729ABDC3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE781EBC5BFC74B682DEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006377E85B0EC44E8FD73EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC76644ADD8EF424FA72137AAB89A1D4157D471EFB5F3B9D9129BC389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B652D31B9D28593E51CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C22496E3E992EC305184376E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8BA21504E42EAD3B7E3AA81AA40904B5D9DBF02ECDB25306B2201CA6A4E26CD07C3BBE47FD9DD3FB595F5C1EE8F4F765FCA83251EDC214901ED5E8D9A59859A8B682BBBAF5DF00056E089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46DAAB84DE5C318ED0D355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A566CFD886D4532C09114A07F30D553BA98B71AA24B208D710D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3454CC76E5F54B410C7E4E90A550AEB0A186153D36615E5E2703CB383A774BBF7612119DEA082041E61D7E09C32AA3244C71269B868EFA70E3BAB3DAF5A9D5A1A08A6D4CC6FBFAC251FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rQ2+0ck6x8Djw== X-Mailru-Sender: 455D65AE3A139168626D8C76E86D3AC05684851530FAC996C3D7E26280864949DDAC019A3742A8B676D79013C85012CDC77752E0C033A69E4BBE7EBD99111A499D0AB74157175C036C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] memprof: report stack resizing as internal event X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" --Apple-Mail=_837D974B-B20F-475F-91B3-1F73A5173F17 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii Hi! Had a good time reading all your comments, thanks! As for the reason I still not blessed this - I got good explanation why stack resizing should be guarded for the whole part of the code it was in original patch, so LGTM. Sergos > On 29 Mar 2021, at 11:35, Igor Munkin wrote: > > On 29.03.21, Igor Munkin wrote: >> Sergey, >> >> On 29.03.21, Sergey Kaplun wrote: >>> Igor, >>> >> >> >> >>>>>> >>>>>> "Feel free to prove the opposite"(c) :) >>>>>> >>>>>> The current naming is much better than the previous one, but I still >>>>>> propose to save the original on and save G(L) into a new variable. >>>>> >>>>> Ignoring for now. >>>> >>>> Well, if you just need my LGTM, you got it. I'll even push this patch by >>>> myself. But try to hear my arguments even if they look like "bred deda". >>> >>> This is not about LGTM, but about a miscommunication, I hope we will >>> understand each other's point of view and come to a consensus. >> >> I see no changes on the branch, hence we won't. Anyway, you have the >> necessary amount of LGTMs, so I'll push your patch to the trunk later. > > Oops, seems you have only mine (at least I see no explicit LGTM from > Sergos in the thread). Will not rush then. > >> >>> >> >> >> >>> >>> -- >>> Best regards, >>> Sergey Kaplun >> >> -- >> Best regards, >> IM > > -- > Best regards, > IM --Apple-Mail=_837D974B-B20F-475F-91B3-1F73A5173F17 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii Hi!

Had a = good time reading all your comments, thanks!

As for the reason I still not blessed = this - I got good 
explanation why stack = resizing should be guarded for the whole
part of = the code it was in original patch, so

LGTM.

Sergos

On 29 = Mar 2021, at 11:35, Igor Munkin <imun@tarantool.org> wrote:

On 29.03.21, Igor Munkin wrote:
Sergey,

On= 29.03.21, Sergey Kaplun wrote:
Igor,


<snipped>


"Feel free to prove the opposite"(c) :)

The current naming is much better than the previous one, but = I still
propose to save the original on and save G(L) into = a new variable.

Ignoring for = now.

Well, if you just need my = LGTM, you got it. I'll even push this patch by
myself. But = try to hear my arguments even if they look like "bred deda".

This is not about LGTM, but about = a miscommunication, I hope we will
understand each other's = point of view and come to a consensus.

I see no changes on the branch, hence we won't. Anyway, you = have the
necessary amount of LGTMs, so I'll push your = patch to the trunk later.

Oops, seems = you have only mine (at least I see no explicit LGTM from
Sergos in the = thread). Will not rush then.




<snipped>


-- 
Best = regards,
Sergey Kaplun

-- 
Best regards,
IM

-- 
Best = regards,
IM

= --Apple-Mail=_837D974B-B20F-475F-91B3-1F73A5173F17--