From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BFB512B00A
	for <tarantool-patches@freelists.org>; Tue,  2 Oct 2018 09:36:47 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Pm9M3DXj1lji for <tarantool-patches@freelists.org>;
	Tue,  2 Oct 2018 09:36:47 -0400 (EDT)
Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 361572ACC8
	for <tarantool-patches@freelists.org>; Tue,  2 Oct 2018 09:36:47 -0400 (EDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: [tarantool-patches] Re: [PATCH 1/3] sql: delete unused code
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <80b97605c05e8de841b476627ca52eda60d77b0e.1538476785.git.avkhatskevich@tarantool.org>
Date: Tue, 2 Oct 2018 16:36:41 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <FF97634F-5119-485D-8C2E-A2BD5109DF4D@tarantool.org>
References: <cover.1538476785.git.avkhatskevich@tarantool.org>
 <cover.1538476785.git.avkhatskevich@tarantool.org>
 <80b97605c05e8de841b476627ca52eda60d77b0e.1538476785.git.avkhatskevich@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Alex Khatskevich <avkhatskevich@tarantool.org>


> diff --git a/src/box/sql/main.c b/src/box/sql/main.c
> index 782f99452..3a01f1207 100644
> --- a/src/box/sql/main.c
> +++ b/src/box/sql/main.c
> @@ -483,105 +483,6 @@ setupLookaside(sqlite3 * db, void *pBuf, int sz, =
int cnt)
> 	return SQLITE_OK;
> }
>=20
> -/*
> - * Free up as much memory as we can from the given database
> - * connection.
> - */
> -int
> -sqlite3_db_release_memory(sqlite3 * db)

You forgot to delete function declaration from sqliteInt.h

> @@ -712,12 +613,6 @@ sqlite3_close(sqlite3 * db)
> 	return sqlite3Close(db, 0);
> }
>=20
> -int
> -sqlite3_close_v2(sqlite3 * db)
> -{
> -	return sqlite3Close(db, 1);
> -}

You deleted not all mentions of sqlite3_close_v2(), just grep it.