From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8ED4A22B74
	for <tarantool-patches@freelists.org>; Fri, 11 May 2018 14:19:00 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 40t_VAAyBnBL for <tarantool-patches@freelists.org>;
	Fri, 11 May 2018 14:19:00 -0400 (EDT)
Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 42BFF22AB3
	for <tarantool-patches@freelists.org>; Fri, 11 May 2018 14:18:59 -0400 (EDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: [tarantool-patches] Re: [PATCH] sql: allow ON CONFLICT REPLACE only
 for PK index
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <20180511060116.pdegorozkbvjccwu@tarantool.org>
Date: Fri, 11 May 2018 21:18:55 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <FED0269C-1826-43B9-AE3E-7E514CFA5CF1@tarantool.org>
References: <20180422073719.13245-1-niatshin@tarantool.org>
 <8920AA01-8BCD-40F3-B6E3-908C5D9A99F6@tarantool.org>
 <20180511060116.pdegorozkbvjccwu@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Kirill Yukhin <kyukhin@tarantool.org>


> On 11 May 2018, at 09:01, Kirill Yukhin <kyukhin@tarantool.org> wrote:
>=20
> Hello Bulat, Nikita,
> On 04 =D0=BC=D0=B0=D1=8F 02:39, n.pettik wrote:
>> I am OK with this patch.
>> I have fixed a few minor codestyle violations and
>> rebased to fresh 2.0
> The patch makes sql/on-conflict test fail.
> Could you pls fix it.
>=20
> --
> Regards, Kirill Yukhin

Well, I don=E2=80=99t have such troubles, everything works fine.
Are you sure that you are using last version?
Branch is bn/gh-2963-proper-replace