From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <roman.habibov@tarantool.org>
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2BED9469719
 for <tarantool-patches@dev.tarantool.org>;
 Sun,  4 Oct 2020 00:37:28 +0300 (MSK)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\))
From: Roman Khabibov <roman.habibov@tarantool.org>
In-Reply-To: <db246d15-f89e-afdd-a2c0-f38e23a04a25@tarantool.org>
Date: Sun, 4 Oct 2020 00:37:26 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <FE059F16-1D6F-472C-A184-41121E2D5DC7@tarantool.org>
References: <20200911215115.6622-1-roman.habibov@tarantool.org>
 <20200911215115.6622-7-roman.habibov@tarantool.org>
 <20200916201823.GE10599@tarantool.org>
 <4b304f32-379a-fb50-f427-615a91646b7d@tarantool.org>
 <20200918125901.GL10599@tarantool.org>
 <9C52EA98-F9AD-44A5-8755-E2A76372964E@tarantool.org>
 <db246d15-f89e-afdd-a2c0-f38e23a04a25@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 6/6] sql: support column addition
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

> On Oct 3, 2020, at 01:08, Vladislav Shpilevoy =
<v.shpilevoy@tarantool.org> wrote:
>=20
> Hi! Thanks for the fixes!
>=20
>>>>> In Postgres for instance, one can add column for non-empty table =
and
>>>>> it is considered to be ok (new column is filled with default =
value).
>>>>> We can use ephemeral tables as temporary holder while rebuilding =
space.
>>>>=20
>>>> Ephemeral spaces can't be used at least because of vinyl, because =
may
>>>> not fit into the memory.
>>>=20
>>> Anyway they are used for vinyl even now.
>>>=20
>>>> With Roman we decided to implement non-empty
>>>> alter later as a separate issue.
>>>=20
>>> Ok, then please create follow-up issue with proposed approach.
>> We may patch the box code and implement DEFAULT (and NULL ?)inside
>> box. This trigger will update space=E2=80=99s tuples during <ALTER =
TABLE ADD COLUMN>.
>> In any case, we need to patch box. We will do it later.
>=20
> I don't think Nikita meant that you need to implement it now. He
> said you need to ensure the task is not lost. So you either need
> to find an existing issue about this, or create a new issue.
https://github.com/tarantool/tarantool/issues/3206=