From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id EF22425EDC for ; Wed, 31 Jul 2019 10:51:22 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CsIjORcjHJrf for ; Wed, 31 Jul 2019 10:51:22 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3571325ED5 for ; Wed, 31 Jul 2019 10:51:22 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [tarantool-patches] Re: [PATCH 5/5] sql: introduce VARBINARY column type From: "n.pettik" In-Reply-To: <80b10469-4c03-f138-fec7-b7a31857cfb8@tarantool.org> Date: Wed, 31 Jul 2019 17:51:18 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <49a188eb-dafe-44e7-a0fd-e9244b68e721@tarantool.org> <1293710C-85CC-4F5A-A7CF-4677D901DCE9@tarantool.org> <24a34647-0d0c-7950-b92e-6c8bf3f16d92@tarantool.org> <63A0BD0D-69A9-4CD6-942B-EB9CDDDB21F3@tarantool.org> <80b10469-4c03-f138-fec7-b7a31857cfb8@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy , Kirill Yukhin > On 30 Jul 2019, at 22:52, Vladislav Shpilevoy = wrote: >=20 > Oh, but wait. Travis is fully red: >=20 > = https://travis-ci.org/tarantool/tarantool/builds/565497371?utm_source=3Dgi= thub_status&utm_medium=3Dnotification >=20 > Looks like you forgot to update plan in sql-tap/func.test.lua. Yep, thanks, fixed. Now gitlab seems to be OK: https://gitlab.com/tarantool/tarantool/pipelines/73961933 > On 30/07/2019 21:41, Vladislav Shpilevoy wrote: >> Hi! Thanks for the fixes! >>=20 >> LGTM. >>=20 >>>>>> 3. BLOB keyword is reserved, but also it is used in parse.y:980. >>>>>> Should not it be deleted from all the rules, and be just >>>>>> reserved? >>>>>=20 >>>>> It=E2=80=99s rule for declaring blob (aka binary string) literals. >>>>> I can rename it, but TBO it looks OK to me. >>>>=20 >>>> Could you please provide an example, how to use BLOB keyword to >>>> declare a literal? I can't find any test, using BLOB in a query >>>> string for anything. >>>=20 >>> I meant that it=E2=80=99s not the rule that allows BLOB keyword but >>> the rule to process X=E2=80=99=E2=80=A6=E2=80=99 literals. When = string is processed by >>> lexer (tokenize.c) its token type is assigned to TK_BLOB. >>=20 >> Ahh, I got it now. BLOB(X) is not a 'BLOB' keyword, it is rather >> like a rule 'BLOB :=3D x...'. Then of course it is ok, nothing to >> do here. >>=20 >=20