From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D609146970E for ; Fri, 7 Feb 2020 12:40:08 +0300 (MSK) From: Chris Sosnin Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_A5945D01-32A6-40E7-8CD4-97C074FFCE30" Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\)) Date: Fri, 7 Feb 2020 12:40:06 +0300 In-Reply-To: References: <20200204193200.61510-1-k.sosnin@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 4/4] sql: provide a user friendly frontend for accessing session settings List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org --Apple-Mail=_A5945D01-32A6-40E7-8CD4-97C074FFCE30 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi! Thank you very much for your fixes! I squashed all of your 4 commits and added some minor changes: =E2=80=94 Fixed indentation in session.c for switch statement =E2=80=94 Removed computation of string length from OP_Set since in = struct Mem we have int n; /* size (in bytes) of string value, excluding = trailing '\0' */ branch: = https://github.com/tarantool/tarantool/tree/ksosnin/gh-4712-search-setting= s = issue #1: https://github.com/tarantool/tarantool/issues/4711 = issue #2: https://github.com/tarantool/tarantool/issues/4712 = --Apple-Mail=_A5945D01-32A6-40E7-8CD4-97C074FFCE30 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hi! Thank you very = much for your fixes!

I= squashed all of your 4 commits and added some minor changes:

=E2=80=94 Fixed indentation in session.c for switch = statement

=E2=80=94 Removed computation of string = length from OP_Set since in struct Mem we have

int n; /* size (in bytes) of string value, = excluding trailing '\0' */

branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4712-sea= rch-settings
issue #1: https://github.com/tarantool/tarantool/issues/4711
issue #2: https://github.com/tarantool/tarantool/issues/4712

= --Apple-Mail=_A5945D01-32A6-40E7-8CD4-97C074FFCE30--