From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8CF6D6F3C7; Fri, 26 Mar 2021 14:35:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8CF6D6F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616758532; bh=v+cKMStCMBWZSaWNYu2rU+KWS54gqXjH48iGb2n6ImY=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=MkyLdBhMIXmEUxM8y0EDHKsJbaHP1tr/1Zhh8abYX6aCyULTz/TiAAy0j4ujUl/Pi BxoHtvOlh1JpD8v4ZCbfGXTS6vgHy7WIT+vPGZfW/yqZem0y+rp9SH7Y+1kIZueVAg MLhXllJT2ouJdH+4zEhfp4u9lPJ9tSifxMCPuM9Q= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6F5466F3C7 for ; Fri, 26 Mar 2021 14:35:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6F5466F3C7 Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1lPkkU-00074n-F1; Fri, 26 Mar 2021 14:35:30 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) In-Reply-To: Date: Fri, 26 Mar 2021 14:35:29 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Sergey Kaplun X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9064ADF4728AA0EE993662DB34D9B1ABD5A9410DDDE83AB43182A05F538085040168B0F0D3D07B4DFA1AB848E6357D8B82867597CB1309942C4D9C23D1907D2BA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063719899BAB9B61B3948638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5DF4D03A1F36F4A9514E3BFEEB486F038EA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7ABB305BD10C6E5099FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C362968DCAA3E4B45B117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73589424AA0EF8DE9BAC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5ABAE819339ED75286F349BB217A5553818F0ABB56D134DB8D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348F9E8EBB46231487B8BDE24C8112F0DE92C7761C6611967240CE2C8AD18EC52CC547EC9B881751D51D7E09C32AA3244C9D6A846AFE43445C7FAE5C8C2CFA24F733C9DC155518937FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAhvaO4lhCpmlQ== X-Mailru-Sender: 3B9A0136629DC912F4AABCEFC589C81ECD123E29E46AB4BF0ABB7AB50D8A2754DB946844D3C7440BAD07DD1419AC565FA614486B47F28B67C5E079CCF3B0523AED31B7EB2E253A9E112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 09/30] test: disable Lua suite tests for line hook X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Follow-up ticket ? LGTM. Sergos > On 26 Mar 2021, at 10:42, Sergey Kaplun wrote: >=20 > FIXME: LuaJIT interprets a return from a new function loaded by > `loadstring()` with a change line number for bytecode position > unlike Lua does. This looks like "implementation-defined behaviour" > mentioned in https://luajit.org/status.html. >=20 > All tests checked the debug hook for a new line of code are affected > and disabled by this patch. >=20 > Relates to tarantool/tarantool#5693 > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/db.lua | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) >=20 > diff --git a/test/PUC-Lua-5.1-tests/db.lua = b/test/PUC-Lua-5.1-tests/db.lua > index 9d2c86f..a8c7196 100644 > --- a/test/PUC-Lua-5.1-tests/db.lua > +++ b/test/PUC-Lua-5.1-tests/db.lua > @@ -95,6 +95,23 @@ repeat > assert(g(f) =3D=3D 'a') > until 1 >=20 > +-- FIXME: LuaJIT interprets a return from calling result of > +-- `loadstring()` with a new line number unlike Lua does. > +-- Here is an example (it is joined in one line intend): > +--[[ > +debug.sethook(function(_, l) print("LINE: "..l) end, "l") = loadstring("\n\ns=3Dnil")() debug.sethook() > +--]] > +-- This chunk prints for LuaJIT: > +--[[ > +LINE: 3 > +LINE: 1 > +--]] > +-- But for Lua 5.1 it is only "LINE: 3" in the output. > +-- See also https://github.com/tarantool/tarantool/issues/5693. > +-- Considering implementation-defined behaviour diference > +-- (see also https://luajit.org/status.html) test is disabled for > +-- LuaJIT. > +--[=3D[ > test([[if > math.sin(1) > then > @@ -149,7 +166,7 @@ end > ]], {1,2,1,2,1,3}) >=20 > test([[for i=3D1,4 do a=3D1 end]], {1,1,1,1,1}) > - > +--]=3D] >=20 >=20 > print'+' > --=20 > 2.31.0 >=20