From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DB82E22433 for ; Sun, 29 Jul 2018 07:23:41 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2qy7Z2tlablI for ; Sun, 29 Jul 2018 07:23:41 -0400 (EDT) Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 44EAD222DF for ; Sun, 29 Jul 2018 07:23:41 -0400 (EDT) From: "n.pettik" Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_87D71DA8-7BD3-4BB1-AE6C-F1C573008F95" Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH] sql: xfer optimization issue Date: Sun, 29 Jul 2018 14:23:30 +0300 In-Reply-To: <20180729011251.eitp7cisv6jv5opj@tkn_work_nb> References: <8B8D5501-075D-4BEB-B282-35B0B81CD555@tarantool.org> <605B15EF-BD1C-4B03-8A9F-6E6225076812@tarantool.org> <12B62C73-9BEC-49FA-B3FD-590C445CF25B@tarantool.org> <2123605D-8D6C-43A3-846F-735E4C2C7FC2@tarantool.org> <20180729011251.eitp7cisv6jv5opj@tkn_work_nb> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Alexander Turenko , "N. Tatunov" --Apple-Mail=_87D71DA8-7BD3-4BB1-AE6C-F1C573008F95 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > 1. Not actual due to 2, but it would be better to use > `pOp->p5 &= ~OPFLAG_XFER_OPT` to drop just that flag. > 2. It is counter-intuitive, IMHO, to change operation flags during that > operation. So, said above, vote to move it to OP_OpenWrite. Well, actually moving it to OP_OpenWrite seems to be bad idea. Even if code for xFer optimisation is generated, it still might not be executed. The only opcode ensuring xFer is under processing - OP_RowData. --Apple-Mail=_87D71DA8-7BD3-4BB1-AE6C-F1C573008F95 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
1. Not actual due to 2, but it = would be better to use
  `pOp->p5 &=3D = ~OPFLAG_XFER_OPT` to drop just that flag.
2. It is counter-intuitive, = IMHO, to change operation flags during that
  operation. So, said above, vote to = move it to OP_OpenWrite.

Well, = actually moving it to OP_OpenWrite seems to be bad idea.
Even = if code for xFer optimisation is generated, it
still might not = be executed. The only opcode ensuring xFer is
under processing = - OP_RowData.

= --Apple-Mail=_87D71DA8-7BD3-4BB1-AE6C-F1C573008F95--