From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 85EE26F3C7; Fri, 26 Mar 2021 17:58:32 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 85EE26F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616770712; bh=CW/nlbCzDHwAfzlcZL2QHx1DqCLkmJfJU5i7YkDaleU=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rKJt377j2JI1UlFx0tLakXQ6h7UXB70VhR7tyXmyzlHuVyYi9pP6FlTE/jewHy+eA AypkE4PO+8jcpcArd42O136fTawWogFCmK80D8rTzedZ8xt44w5Z+TgKq1TdaqeVFn jIQOU+CY9A2bXLzeHy2Mha1vzsEbpmbLd+q45sbU= Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DAEBF6F3C7 for ; Fri, 26 Mar 2021 17:58:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DAEBF6F3C7 Received: by smtp35.i.mail.ru with esmtpa (envelope-from ) id 1lPnuw-0005O9-7B; Fri, 26 Mar 2021 17:58:30 +0300 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) In-Reply-To: <86ead4f35be1f65e9e4c0e46715d42a05851ba6d.1616743343.git.skaplun@tarantool.org> Date: Fri, 26 Mar 2021 17:58:29 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <86ead4f35be1f65e9e4c0e46715d42a05851ba6d.1616743343.git.skaplun@tarantool.org> To: Sergey Kaplun X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294DD38BE31D7797EF84C856624A09E4809182A05F5380850400995FD9F4F880B0CB05E503D373A47901BE1F281F9DD40C9A86D12BF6C310DC1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F9D3BE5B596754B8C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7364F8074C6DFACE28F08D7030A58E5ADC58D69EE07B14084C6CDE5D1141D2B1C2F180AB5A9A740A49E3E381C53404B6F4A881905A6169B599FA2833FD35BB23D9E625A9149C048EE33AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B1F8789D36234D406A471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249B372FE9A2E580EFC725E5C173C3A84C3A1C30C8AFC676C8B35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A546DEDD6134A318582FADD368B703697CFE0D4602A591881CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34ADE558D2B396DA7CE222D0BFD9D1BCB5107B9047BDACC516AE955A5BE91D7D6C677E6A99C397A0491D7E09C32AA3244CFA8F3119C7D386B1B1891D7401E6A5C2795D98D676DD64D0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAgB6DuCOmliIg== X-Mailru-Sender: 3B9A0136629DC912F4AABCEFC589C81EFC8D8143C42AF4DA5886BE2936F0D05636799F91EFF50B36AD07DD1419AC565FA614486B47F28B67C5E079CCF3B0523AED31B7EB2E253A9E112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 17/30] test: disable locale-depended tests for Lua suite X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" LGTM. Sergos > On 26 Mar 2021, at 10:43, Sergey Kaplun wrote: >=20 > LuaJIT doesn't compare strings by `strcoll()`, like Lua 5.1 does. > So locale-depended tests in are disabled. >=20 > Also, LuaJIT doesn't use `strtod()` depended on the locale for = parsing, > unlike Lua does. See for more info. > Locale-depended tests in are disabled. >=20 > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/literals.lua | 5 +++++ > test/PUC-Lua-5.1-tests/strings.lua | 5 +++++ > 2 files changed, 10 insertions(+) >=20 > diff --git a/test/PUC-Lua-5.1-tests/literals.lua = b/test/PUC-Lua-5.1-tests/literals.lua > index 01d84d5..1b4f664 100644 > --- a/test/PUC-Lua-5.1-tests/literals.lua > +++ b/test/PUC-Lua-5.1-tests/literals.lua > @@ -158,6 +158,10 @@ end >=20 >=20 > -- testing decimal point locale > +-- LuaJIT: LuaJIT doesn't use `strtod()` depended on the locale, > +-- unlike Lua does. See for more info. > +-- Tests are disabled for LuaJIT. > +--[[ > if os.setlocale("pt_BR") or os.setlocale("ptb") then > assert(tonumber("3,4") =3D=3D 3.4 and tonumber"3.4" =3D=3D nil) > assert(assert(loadstring("return 3.4"))() =3D=3D 3.4) > @@ -171,6 +175,7 @@ else > (Message or print)( > '\a\n >>> pt_BR locale not available: skipping decimal point tests = <<<\n\a') > end > +--]] >=20 >=20 > print('OK') > diff --git a/test/PUC-Lua-5.1-tests/strings.lua = b/test/PUC-Lua-5.1-tests/strings.lua > index 7c1dfb8..6ae3f51 100644 > --- a/test/PUC-Lua-5.1-tests/strings.lua > +++ b/test/PUC-Lua-5.1-tests/strings.lua > @@ -162,6 +162,10 @@ local function trylocale (w) > return false > end >=20 > +-- LuaJIT: LuaJIT doesn't compare strings by `strcoll()`, > +-- like Lua 5.1 does. > +-- Tests are disabled for LuaJIT. > +--[[ > if not trylocale("collate") then > print("locale not supported") > else > @@ -176,6 +180,7 @@ else > assert(string.gsub("=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD", "%u", = "x") =3D=3D "=EF=BF=BDx=EF=BF=BDx") > assert(string.upper"=EF=BF=BD=EF=BF=BD=EF=BF=BD{xuxu}=EF=BF=BD=EF=BF=BD= o" =3D=3D "=EF=BF=BD=EF=BF=BD=EF=BF=BD{XUXU}=EF=BF=BD=EF=BF=BDO") > end > +--]] >=20 > os.setlocale("C") > assert(os.setlocale() =3D=3D 'C') > --=20 > 2.31.0 >=20