From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 35AF9267EC for ; Mon, 4 Feb 2019 10:50:34 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cl7hXiVsyeYz for ; Mon, 4 Feb 2019 10:50:34 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E6305267E5 for ; Mon, 4 Feb 2019 10:50:33 -0500 (EST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: [tarantool-patches] Re: [PATCH] sql: remove tests on ORDER BY/LIMIT + DELETE From: "n.pettik" In-Reply-To: <20190204153458.12559-1-ivan.koptelov@tarantool.org> Date: Mon, 4 Feb 2019 18:50:31 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20190204153458.12559-1-ivan.koptelov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Ivan Koptelov > On 4 Feb 2019, at 18:34, Ivan Koptelov = wrote: >=20 > Removes obsolete tests on ORDER BY/LIMIT + DELETE. This > functionality was not supported for some time, but a few tests > were still existing. >=20 > Closes #2172 > --- > Branch = https://github.com/tarantool/tarantool/compare/sudobobo/gh-2172-rm-order-b= y-and-limit-from-delete > Issue https://github.com/tarantool/tarantool/issues/2172 >=20 > test/sql-tap/e_delete.test.lua | 188 = ----------------------------------------- > 1 file changed, 188 deletions(-) >=20 > diff --git a/test/sql-tap/e_delete.test.lua = b/test/sql-tap/e_delete.test.lua > index 84a4e0a22..0a81eb3bd 100755 > --- a/test/sql-tap/e_delete.test.lua > +++ b/test/sql-tap/e_delete.test.lua > @@ -305,194 +305,6 @@ if (0 > 0) then > DELETE FROM t8 NOT INDEXED WHERE a=3D5; > END;]], {"NOT INDEXED"}}, > }) > - -- EVIDENCE-OF: R-64942-06615 The LIMIT and ORDER BY clauses = (described > - -- below) are unsupported for DELETE statements within triggers. > - =E2=80=94 If I=E2=80=99m not mistaken, tests starting from e_delete-2.0 are = disabled (under if 0 > 0). So you can delete even more tests. Also, check SQLITE_ENABLE_UPDATE_DELETE_LIMIT define: I guess it is related to this patch. Seems that it is turned off, so I assume we can delete it alongside with code under it. =20