From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A051B20B2E for ; Tue, 11 Dec 2018 13:29:28 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tApgCD7pqLRc for ; Tue, 11 Dec 2018 13:29:28 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 60122210DE for ; Tue, 11 Dec 2018 13:29:28 -0500 (EST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: [tarantool-patches] Re: [PATCH 4/6] sql: don't add string of 'CREATE TABLE...' to space opts From: "n.pettik" In-Reply-To: <6965549c-a919-0460-2603-b4765a32e338@tarantool.org> Date: Tue, 11 Dec 2018 21:29:26 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <8d774a673688db0503e67b05be1ece319bfd9ea4.1544387419.git.korablev@tarantool.org> <6965549c-a919-0460-2603-b4765a32e338@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy > On 10 Dec 2018, at 17:17, Vladislav Shpilevoy = wrote: >=20 > Thanks for the patch! See 1 comment and review fixes below. >=20 > On 10/12/2018 00:30, Nikita Pettik wrote: >> We don't rely no more on this string anymore and it can be removed = for >=20 > 'no more on this anymore' - please, rephrase. Sounds a little > tautological. Rephrased: =20 We don't rely on this string anymore and it can be removed for = ordinary tables. However, it is still used to hold SELECT body for view. >=20 >> ordinary tables. However, it is still used to hold SELECT body for = view. >> Part of #2647 >> --- >> src/box/sql.c | 8 +- >> src/box/sql/analyze.c | 2 +- >> src/box/sql/build.c | 242 = ++---------------------------------------------- >> src/box/sql/pragma.c | 2 - >> src/box/sql/sqliteInt.h | 1 - >> test/sql/upgrade.result | 8 +- >> test/sql/view.result | 3 + >> test/sql/view.test.lua | 1 + >> 8 files changed, 19 insertions(+), 248 deletions(-) >=20 > My review fix here and on the branch: Applied.