From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4C96F240EA
	for <tarantool-patches@freelists.org>; Wed, 24 Jul 2019 09:23:46 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id zVwCnrSspVcC for <tarantool-patches@freelists.org>;
	Wed, 24 Jul 2019 09:23:46 -0400 (EDT)
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0ACC72405D
	for <tarantool-patches@freelists.org>; Wed, 24 Jul 2019 09:23:45 -0400 (EDT)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\))
Subject: [tarantool-patches] Re: [PATCH 2/2] sql: transactional DDL
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <bc55c527-0952-3d1b-d16e-4de844869927@tarantool.org>
Date: Wed, 24 Jul 2019 16:23:42 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <F05B7622-DD90-4826-BB5C-2B6D9487DAC4@tarantool.org>
References: <cover.1563576462.git.v.shpilevoy@tarantool.org>
 <5863bb4286a3e45b3521420273d89347bd331a92.1563576462.git.v.shpilevoy@tarantool.org>
 <FE023A3F-AF35-41D8-BC46-490095333C19@tarantool.org>
 <bc55c527-0952-3d1b-d16e-4de844869927@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>


Thanks, the only dubious nit I can spot: should we
set initiateTTrans for DDL operations which consist
of one box operations? Like: create index, drop index,
create trigger, drop trigger, drop constraint etc
For instance, we don=E2=80=99t set it for TRUNCATE stmt.
The only two operations which require starting transactions
are CREATE TABLE and RENAME. Btw, when checking
results of RENAME I=E2=80=99d also check that operation (update of
=E2=80=98CREATE TRIGGER =E2=80=A6' string) performed on _trigger has
been committed/rollbacked.