From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 80ABA247E7
	for <tarantool-patches@freelists.org>; Wed, 14 Aug 2019 10:35:26 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id m5SEUh3otf8D for <tarantool-patches@freelists.org>;
	Wed, 14 Aug 2019 10:35:26 -0400 (EDT)
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CAD9C22DFA
	for <tarantool-patches@freelists.org>; Wed, 14 Aug 2019 10:35:25 -0400 (EDT)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: [tarantool-patches] Re: [PATCH] sql: remove unused mask
From: Roman Khabibov <roman.habibov@tarantool.org>
In-Reply-To: <C7B7DBF0-8141-4438-B280-DABAD2BCCA99@tarantool.org>
Date: Wed, 14 Aug 2019 17:35:22 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <EF5D0F6E-4C6C-458D-9650-2AA2262A6333@tarantool.org>
References: <20190802124629.54302-1-roman.habibov@tarantool.org>
 <C7B7DBF0-8141-4438-B280-DABAD2BCCA99@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Vlad, could you do a second review?

> On Aug 9, 2019, at 18:46, n.pettik <korablev@tarantool.org> wrote:
>=20
>=20
>=20
>> On 2 Aug 2019, at 15:46, Roman Khabibov <roman.habibov@tarantool.org> =
wrote:
>>=20
>> Field mask of "struct Keyword" is always set to one not null
>> macroses and used only once for checking that it isn't null. So,
>> the field should be removed.
>>=20
>> Closes #4155
>=20
> I=E2=80=99ve fixed commit message and force pushed.
>=20
>    sql: remove mask from struct Keyword
>=20
>    Originally, mask in struct Keyword served to reduce set of reserved
>    keywords for build-dependent features. For instance, it was allowed =
to
>    disable triggers as a compilation option, and in this case TRIGGER
>    wouldn't be reserved word. Nowadays, our build always comprises all
>    features, so there's no need in this option anymore. Hence, we can
>    remove mask alongside with related to it macros.
>=20
>    Closes #4155
>=20
> The rest is OK as obvious.