From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D8D0826EF7 for ; Tue, 12 Feb 2019 12:05:54 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xmZ270uAbME7 for ; Tue, 12 Feb 2019 12:05:54 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 2AE47267FE for ; Tue, 12 Feb 2019 12:05:54 -0500 (EST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: [tarantool-patches] Re: [PATCH v4 1/2] sql: remove useless pragmas From: "n.pettik" In-Reply-To: <20190212073151.27230-1-szudin@tarantool.org> Date: Tue, 12 Feb 2019 20:05:51 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20190212073151.27230-1-szudin@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: szudin@tarantool.org When you send patch consisting from >=3D 2 commits, you should organise it as patch-set with covering letter: https://tarantool.io/en/doc/2.1/dev_guide/developer_guidelines/ Quote: =E2=80=98'' If there are multiple patches you want to submit in one go (e.g. this is = a big feature which requires some preparatory patches to be committed = first), you should send each patch in a separate email in reply to a = cover letter. To format a patch series accordingly, pass the following = options to git format-patch: =E2=80=A6 =E2=80=98=E2=80=99' > On 12 Feb 2019, at 10:31, Stanislav Zudin = wrote: >=20 > The pragmas "query_only" and "read_uncommitted" didn't affect anything > and were removed. > Fixed an error in pragma index_list which caused a segmantation fault. > pragma sql_default_engine accepts only strings. > Thus pragma sql_default_engine('memtx') is a well-formed command, > while pragma sql_default_engine(memtx) or > pragma sql_default_engine("memtx") are considered as ill-formed and > raise an error. >=20 > Closes #3733 You twice close issue - in both commits. Please, do it only in the last one. The rest in this patch is OK.=