From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 36A16271B5 for ; Fri, 8 Feb 2019 09:03:43 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g6OfDfvWv1fN for ; Fri, 8 Feb 2019 09:03:43 -0500 (EST) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7BAB326F51 for ; Fri, 8 Feb 2019 09:03:42 -0500 (EST) From: "n.pettik" Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_E7024629-0538-4BAE-90D4-F21D8FA87A36" Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: [tarantool-patches] Re: [PATCH] sql: remove useless pragmas Date: Fri, 8 Feb 2019 17:03:39 +0300 In-Reply-To: References: <20190206121822.9534-1-szudin@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: szudin@tarantool.org --Apple-Mail=_E7024629-0538-4BAE-90D4-F21D8FA87A36 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 8 Feb 2019, at 13:17, Stanislav Zudin wrote: >=20 > On 06.02.2019 16:21, n.pettik wrote: >>=20 >>> On 6 Feb 2019, at 15:18, Stanislav Zudin > wrote: >>>=20 >>> The pragmas "query_only" and "read_uncommitted" didn't affect = anything and were removed. >> Nit: please, fit commit message into 72 symbols. > Mea culpa >>=20 >> What about =E2=80=9Cbusy_timeout=E2=80=9D? As I see from code it is = also useless. >> It may require to delete some code more code. > It calls sqlite_busy_handler. Does this feature work? No, it doesn=E2=80=99t. You can remove it in a separate patch.= --Apple-Mail=_E7024629-0538-4BAE-90D4-F21D8FA87A36 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 8 Feb 2019, at 13:17, Stanislav Zudin <szudin@tarantool.org> wrote:

On 06.02.2019 16:21, n.pettik = wrote:

On 6 Feb 2019, at 15:18, = Stanislav Zudin <szudin@tarantool.org> wrote:

The pragmas "query_only" and "read_uncommitted" didn't affect = anything and were removed.
Nit: please, fit = commit message into 72 symbols.
Mea culpa

What about =E2=80=9Cbusy_timeout=E2=80=9D? As I see from code = it is also useless.
It may require to delete some code = more code.
It calls sqlite_busy_handler. Does this feature = work?

No, = it doesn=E2=80=99t. You can remove it in a separate = patch.
= --Apple-Mail=_E7024629-0538-4BAE-90D4-F21D8FA87A36--