From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4AF5527C93
	for <tarantool-patches@freelists.org>; Wed,  1 Aug 2018 16:54:36 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id VTqSf_Uvqgl5 for <tarantool-patches@freelists.org>;
	Wed,  1 Aug 2018 16:54:36 -0400 (EDT)
Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0B7AB270D1
	for <tarantool-patches@freelists.org>; Wed,  1 Aug 2018 16:54:35 -0400 (EDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: [tarantool-patches] Re: [PATCH 1/5] sql: prohibit creation of FK on
 unexisting tables
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <33d5fa73-76a8-9402-e535-4612d7b25c62@tarantool.org>
Date: Wed, 1 Aug 2018 23:54:33 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <EA969AFF-7424-4BF5-A62E-5BBBA88EA8EC@tarantool.org>
References: <cover.1531443603.git.korablev@tarantool.org>
 <32f36b207de86bf144b16260c9ed434b45cf094c.1531443603.git.korablev@tarantool.org>
 <b46ace50-6ebc-82b2-0bab-6ccc3b378dee@tarantool.org>
 <0176472E-E0CD-41F9-B794-45E02FA54238@tarantool.org>
 <33d5fa73-76a8-9402-e535-4612d7b25c62@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>


> 1. sql-tap/fkey2.test.lua fails on this commit. Travis fails
> as well.

Does it really matter?:) Could you forgive me these fails and
make me avoid suffering? Anyway, they are completely fixed
in second patch, but in scope of current patch they can be only
partially repaired. Hence, it would look like I fix in the second patch
fixes made in first one..

> 2. I have pushed more review fixes in a separate commit (the
> test fails before it too). Please, squash if you are ok.

Ok, I=E2=80=99ve squashed them.