From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3CD25228A7 for ; Fri, 4 May 2018 05:50:43 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U7barZGomA0e for ; Fri, 4 May 2018 05:50:43 -0400 (EDT) Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 6D985220F0 for ; Fri, 4 May 2018 05:50:42 -0400 (EDT) Content-Type: multipart/alternative; boundary="Apple-Mail=_7E1B2517-FCB5-4826-A6BF-C9618A1E5BC5" Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH] sql: Fixes op-codes' generation for skip-scan From: "n.pettik" In-Reply-To: <1525421405.73000074@f511.i.mail.ru> Date: Fri, 4 May 2018 12:50:29 +0300 Message-Id: References: <20180427100613.94160-1-ivan.koptelov@tarantool.org> <1525421405.73000074@f511.i.mail.ru> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Ivan Koptelov --Apple-Mail=_7E1B2517-FCB5-4826-A6BF-C9618A1E5BC5 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii > I am confused. 72 chars is a limit for the whole commit > message? 72 for commit message body, 50 for commit subject. > I am confused again. What is this 80-chars constraint about? This is *acceptable* limit of symbols per line in source code. Notice, that for comments in code it is 66 chars. Your fix violates this rule: line is about 84 chars. Also, we are going to support static types soon, so lets add types for all tests in your suite. --Apple-Mail=_7E1B2517-FCB5-4826-A6BF-C9618A1E5BC5 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii
=
I am confused. 72 chars is a limit for the whole commit
message? 
<= /div>

72 = for commit message body, 50 for commit subject.

=
I am confused again. What is this 80-chars constraint = about?

This is = *acceptable* limit of symbols per line in source code.
Notice, = that for comments in code it is 66 chars.
Your fix violates this = rule: line is about 84 chars.

Also, we are going to support static types = soon,
so lets add types for all tests in your suite.

= --Apple-Mail=_7E1B2517-FCB5-4826-A6BF-C9618A1E5BC5--