`os.time()` uses `mktime()` to specify time by the given table.
`mktime()` produces the call to `tzset()` to determine the system's
timezone. If the TZ variable does not appear in the environment, the
system timezone is used. The system timezone is configured by copying,
or linking, a file in the tzfile(5) format to /etc/localtime. So, if
this file is omitted (like in RED OS), the errno is set to a non-zero
value. This leads to the nil returned by the `os.time()` for -1 time
value.
This patch skips the test if this file is missed to be sure that we
don't obtain any false positive failures due to system
misconfigurations.
Branch:
https://github.com/tarantool/luajit/tree/skaplun/fix-os-time-test-redosFailed workflow:
https://github.com/tarantool/tarantool/actions/runs/28585213455/job/84775371860?pr=12886#step:5:20692Tested inside the following Docker:
FROM registry.red-soft.ru/ubi8/ubi-minimal:latest
RUN dnf update -y && \
dnf install -y cmake vim make git curl gcc g++ gdb man && \
dnf clean all
| docker build . --tag redos
| docker run --network=host -ti redos bash
Then clone LuaJIT and proceed as usual.
With the patch the test skipped:
| 1..0 # SKIP Unconfigured timezone rules
Changes in v2:
* Skip patch not for RED OS but for all distributions with unconfigured
timezones (i.e. missing '/etc/localtime').
.../lj-1470-os-time-epoch-minus-1s.test.lua | 20 ++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua b/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
index dfe1ee11..48c6c3a3 100644
--- a/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
+++ b/test/tarantool-tests/lj-1470-os-time-epoch-minus-1s.test.lua
@@ -1,9 +1,27 @@
local tap = require('tap')
+local function unconfigured_timezone()
+ -- `os.time()` uses `mktime()` to specify time by the given
+ -- table. `mktime()` produces the call to `tzset()` to determine
+ -- the system's timezone.
+ -- If the TZ variable does not appear in the environment, the
+ -- system timezone is used. The system timezone is configured by
+ -- copying, or linking, a file in the tzfile(5) format to
+ -- /etc/localtime. So, if this file is omitted, the errno is
+ -- set to a non-zero value. This leads to the nil returned by
+ -- the `os.time()` for -1 time value. Let's skip the test if
+ -- this file is missed to be sure that we don't obtain any false
+ -- positive failures due to system misconfigurations.
+ local f = io.open('/etc/localtime', 'r')
+ return not f
+end
+
-- The test file demonstrates os.time() fail to return -1 time
-- value.
-- See also:
https://github.com/LuaJIT/LuaJIT/issues/1470.
-local test = tap.test('lj-1470-os-time-epoch-minus-1s')
+local test = tap.test('lj-1470-os-time-epoch-minus-1s'):skipcond({
+ ['Unconfigured timezone rules'] = unconfigured_timezone(),
+})
test:plan(1)