On 17 Aug 2018, at 11:25, Alex Khatskevich <avkhatskevich@tarantool.org> wrote:

On 16.08.2018 20:00, N.Tatunov wrote:

GLOB is a legacy extension for LIKE from SQLite. As we want our SQL to
be close to ANSI SQL & LIKE to depend on collations, we do not want to
support it. This patch totally removes it from Tarantool along with any
mentions of it.

1.We delete it because it is not working properly, and instead of fixing it we
want to replace it with more general regexp. Delete other unnecessary thoughts
from this message.
2. Do not use "we", "our" in commit messages.

 static int
 sql_utf8_pattern_compare(const char *pattern,
   const char *string,
-  const struct compareInfo *pInfo,
-  UChar32 matchOther)
+  const int *is_like_ci,

Pass this parameter by value.

+  UChar32 match_other)
 {
  /* Next pattern and input string chars */
  UChar32 c, c2;
- /* "?" or "_" */
- UChar32 matchOne = pInfo->matchOne;
- /* "*" or "%" */
- UChar32 matchAll = pInfo->matchAll;
- /* True if uppercase==lowercase */
- UChar32 noCase = pInfo->noCase;
+ /* "_" */
+ UChar32 match_one = '_';
+ /* "%" */
+ UChar32 match_all = '%';

This variables consumes stack. Can they be moved to defines?
If it will break smth, make them const.

 int
-sqlite3_strlike(const char *zPattern, const char *zStr, unsigned int esc)
+sql_strlike_ci(const char *zPattern, const char *zStr, unsigned int esc)
 {
- return sql_utf8_pattern_compare(zPattern, zStr, &likeInfoNorm, esc);
+ return sql_utf8_pattern_compare(zPattern, zStr, &case_insensitive_like, esc);

Hardcode `case_insensitive_like` value here.

+ /**
+  * Limit the length of the LIKE pattern to avoid problems
+  * of deep recursion and N*N behavior in

I thought that only globe could require N*N time. Check delete the comment.

-      "ESCAPE expression must be a single character",
+      "ESCAPE expression must be a"
+      " single character",

Do not split error messages at the middle of a sentence. It makes errors ungreppable.
Make it <80 somehow different.

- sqlite3_result_error(context, "LIKE or GLOB pattern can only"
-      " contain UTF-8 characters", -1);
+ sqlite3_result_error(context, "LIKE pattern can only contain"
+      " UTF-8 characters", -1);

Do not split error messages at the middle of a sentence. Make it <80 somehow different.

+ int *is_like_ci;
+ if (is_case_sensitive)
+ is_like_ci = (int *)&case_sensitive_like;

pass this var by value.

diff --git a/test/sql-tap/alter.test.lua b/test/sql-tap/alter.test.lua
index cfe2801..773bdeb 100755
--- a/test/sql-tap/alter.test.lua
+++ b/test/sql-tap/alter.test.lua
@@ -230,9 +230,10 @@ test:do_execsql_test(
 test:do_execsql_test(
     "alter-5.1",
     [[
+        PRAGMA case_sensitive_like = true;
         CREATE TABLE xyz(x PRIMARY KEY);
         ALTER TABLE xyz RENAME TO "xyz1234abc";
-        SELECT "name" FROM "_space" WHERE "name" GLOB 'xyz*';
+        SELECT "name" FROM "_space" WHERE "name" LIKE 'xyz%';

This test become unreasonably complex.
Do just "select where name = 'xyz1234abc'
Or at least delete case_sensitive…

     ]], {
         -- <alter-5.1>
         "xyz1234abc"
@@ -243,7 +244,8 @@ test:do_execsql_test(
     "alter-5.2",
     [[
         ALTER TABLE "xyz1234abc" RENAME TO xyzabc;
-        SELECT "name" FROM "_space" WHERE "name" GLOB 'XYZ*';
+        SELECT "name" FROM "_space" WHERE "name" LIKE 'XYZ%';
+        PRAGMA case_sensitive_like = false;

This test become unreasonably complex.
Do just "select where name = ‘xyz1234abc'

--- NOTE: This test needs refactoring after deletion of GLOB &
---  type restrictions for LIKE. (See #3572)
---    {"LIKE", "like"},
---    {"GLOB", "glob"},
+    {"LIKE", "like"},
     {"AND", "and"},
     {"OR", "or"},
     {"MATCH", "match"},
@@ -98,12 +95,9 @@ operations = {
     {"+", "-"},
     {"<<", ">>", "&", "|"},
     {"<", "<=", ">", ">="},
--- NOTE: This test needs refactoring after deletion of GLOB &
---  type restrictions for LIKE. (See #3572)
 -- Another NOTE: MATCH & REGEXP aren't supported in Tarantool &
---   are waiting for their hour, don't confuse them
---  being commented with ticket above.
-    {"=", "==", "!=", "<>"}, --"LIKE", "GLOB"}, --"MATCH", "REGEXP"},
+--   are waiting for their hour.
+    {"=", "==", "!=", "<>", "LIKE"}, --"MATCH", "REGEXP"},
     {"AND"},
     {"OR"},
 }
@@ -128,7 +122,7 @@ end
 -- EVIDENCE-OF: R-15514-65163 SQLite understands the following binary
 -- operators, in order from highest to lowest precedence: || * / % + -
 -- << >> & | < <= > >= = == != <> IS IS
--- NOT IN LIKE GLOB MATCH REGEXP AND OR
+-- NOT IN LIKE MATCH REGEXP AND OR
 --
 -- EVIDENCE-OF: R-38759-38789 Operators IS and IS NOT have the same
 -- precedence as =.
@@ -467,18 +461,63 @@ literals = {
 for _, op in ipairs(oplist) do
     for n1, rhs in ipairs(literals) do
         for n2, lhs in ipairs(literals) do
-            local t = test:execsql(string.format(" SELECT typeof(%s %s %s) ", lhs, op, rhs))[1]
-            test:do_test(
-                string.format("e_expr-7.%s.%s.%s", opname[op], n1, n2),
-                function()
-                    --print("\n op "..op.." t "..t)
-                    return (((op == "||") and ((t == "text") or
-                            (t == "null"))) or
-                            ((op ~= "||") and (((t == "integer") or
-                                    (t == "real")) or
-                                    (t == "null")))) and 1 or 0
-                end, 1)
+            if op ~= "LIKE" then

1. Why do not just delete like from `oplist`?
2. We were discussing this place with you and Georgy, and decided that you do
not touch this for loop at all.

-local function glob(args)
-    return 1
-end
 -box.internal.sql_create_function("GLOB", glob)
-box.internal.sql_create_function("MATCH", glob)
-box.internal.sql_create_function("REGEXP", glob)
+-- NOTE: GLOB is removed from Tarantool, thus it'll be needed to
+--       refactor these calls. They don't work right now since
+--          we don't support MATHC & REGEXP.
+-- local function glob(args)
+--     return 1
+-- end

This test do not test the glob function. Delete this comment.

+
+-- box.internal.sql_create_function("MATCH", glob)
+-- box.internal.sql_create_function("REGEXP", glob)

You was lucky that commenting those lines do not break the tests. (because there is a similar
code above)
Return it back.

@@ -2274,15 +2312,23 @@ test:do_execsql_test(
         -- </e_expr-16.1.7>
     })
 --- EVIDENCE-OF: R-52087-12043 The GLOB operator is similar to LIKE but
--- uses the Unix file globbing syntax for its wildcards.
---
--- EVIDENCE-OF: R-09813-17279 Also, GLOB is case sensitive, unlike LIKE.
+-- EVIDENCE-OF: R-52087-12043 LIKE doesn't use Unix file globbing
+-- syntax for its wildcards.

Those test was designed especially for the glob function.
There are similar tests for like above.
You should delete it instead of renaming.

 --- EVIDENCE-OF: R-39616-20555 Both GLOB and LIKE may be preceded by the
+-- EVIDENCE-OF: R-39616-20555 LIKE may be preceded by the
 -- NOT keyword to invert the sense of the test.
 --
 test:do_execsql_test(
+    "e_expr-17.2.0",
+    [[
+        SELECT 'abcxyz' NOT LIKE 'ABC%'
+    ]], {
+        -- <e_expr-17.2.0>
+        1
+        -- </e_expr-17.2.0>
+    })
+
+test:do_execsql_test(
     "e_expr-17.2.1",
     [[
-        SELECT 'abcxyz' NOT GLOB 'ABC*'
+        SELECT 'abcxyz' NOT LIKE 'abc%'
     ]], {
         -- <e_expr-17.2.1>
-        1
+        0
         -- </e_expr-17.2.1>
     })
   test:do_execsql_test(
     "e_expr-17.2.2",
     [[
-        SELECT 'abcxyz' NOT GLOB 'abc*'
+        PRAGMA case_sensitive_like = 0
     ]], {
         -- <e_expr-17.2.2>
-        0
-        -- </e_expr-17.2.2>
+
+        -- <e_expr-17.2.2>
     })
   test:do_execsql_test(
@@ -2405,10 +2461,11 @@ test:do_execsql_test(
 -- MUST_WORK_TEST uses access to nullvalue... (sql parameters) and built in functions
 if 0>0 then
     db("nullvalue", "null")

do not change tests which are not working.
There is a chance chat you do it wrong and you do not know about it.

diff --git a/test/sql-tap/like3.test.lua b/test/sql-tap/like3.test.lua
index 505d2fa..0bc71a0 100755
--- a/test/sql-tap/like3.test.lua
+++ b/test/sql-tap/like3.test.lua
@@ -12,13 +12,13 @@ test:plan(7)
 --    May you find forgiveness for yourself and forgive others.
 --    May you share freely, never taking more than you give.
 --
--------------------------------------------------------------------------
+-----------------------------------------------------------------
 --
--- This file implements regression tests for SQLite library.  The
--- focus of this file is testing the LIKE and GLOB operators and
--- in particular the optimizations that occur to help those operators
--- run faster and that those optimizations work correctly when there
--- are both strings and blobs being tested.
+-- This file implements regression tests for SQLite library. The
+-- focus of this file is testing the LIKE operator and
+-- in particular the optimizations that occur to help this
+-- operator run faster and that those optimizations work
+-- correctly when there are both strings and blobs being tested.
 --
 -- Ticket 05f43be8fdda9fbd948d374319b99b054140bc36 shows that the following
 -- SQL was not working correctly:
@@ -70,10 +70,11 @@ test:do_execsql_test(
 test:do_execsql_test(
     "like3-2.0",
     [[
+        PRAGMA case_sensitive_like = 1;
         CREATE TABLE t2(a PRIMARY KEY, b TEXT);
         INSERT INTO t2 SELECT a, b FROM t1;
         CREATE INDEX t2ba ON t2(b,a);
-        SELECT a, b FROM t2 WHERE b GLOB 'ab*' ORDER BY +a;
+        SELECT a, b FROM t2 WHERE b LIKE 'ab%' ORDER BY +a;

Those tests were especially created for glob. Delete it instead of renaming.