From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A321B29C61 for ; Wed, 10 Apr 2019 20:08:26 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H3ZW3JgzhvP2 for ; Wed, 10 Apr 2019 20:08:26 -0400 (EDT) Received: from smtp1.mail.ru (smtp1.mail.ru [94.100.179.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5DDBA27932 for ; Wed, 10 Apr 2019 20:08:26 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: [tarantool-patches] Re: [PATCH v1 2/3] sql: remove unused macros in SQL From: "n.pettik" In-Reply-To: <7654181f806322478e4de2b4c9c800fd5fa33077.1554830037.git.imeevma@gmail.com> Date: Thu, 11 Apr 2019 03:08:23 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <7654181f806322478e4de2b4c9c800fd5fa33077.1554830037.git.imeevma@gmail.com> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Imeev Mergen > On 9 Apr 2019, at 20:17, imeevma@tarantool.org wrote: >=20 > Thise macros unused and should be removed. Nit: these. Nit: are unused. Are you sure that you=E2=80=99ve removed *all* unused macros? Otherwise, which attribute are you used to spot this group of macros?