From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 104312434D
	for <tarantool-patches@freelists.org>; Mon, 14 May 2018 09:55:25 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id U9m4CUzThf54 for <tarantool-patches@freelists.org>;
	Mon, 14 May 2018 09:55:24 -0400 (EDT)
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 45D7223E3C
	for <tarantool-patches@freelists.org>; Mon, 14 May 2018 09:55:24 -0400 (EDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: [tarantool-patches] Re: [PATCH 4/4] sql: move SQL statistics to
 server
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <1b473c97-3975-4679-c260-2ff7269d0a6a@tarantool.org>
Date: Mon, 14 May 2018 16:55:17 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <DE5B9623-7359-479B-BC7B-B6700D213123@tarantool.org>
References: <cover.1524515002.git.korablev@tarantool.org>
 <291aa5961a366c81ffa7ea465636125617a78dad.1524515002.git.korablev@tarantool.org>
 <1dd6cfc3-25f1-8184-df64-2e1638ad55a0@tarantool.org>
 <8E69DCFF-0088-4FCD-A4CA-E3C98DEF7274@tarantool.org>
 <1f4a08f6-366d-8d0c-ec5c-9e8e33a766ee@tarantool.org>
 <81C6752B-7CC6-4AED-9199-5471204C18CF@tarantool.org>
 <1b473c97-3975-4679-c260-2ff7269d0a6a@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>


> No, I checked that. The code below is compiled ok. So you can remove =
the cast and
> z variable.
>=20
> diff --git a/src/box/sql/analyze.c b/src/box/sql/analyze.c
> index 4f21cd25f..061fcc7ab 100644
> --- a/src/box/sql/analyze.c
> +++ b/src/box/sql/analyze.c
> @@ -1230,7 +1230,7 @@ struct analysis_index_info {
> static void
> decode_stat_string(const char *stat_string, int stat_size, tRowcnt =
*stat_exact,
>                   LogEst *stat_log) {
> -       char *z =3D (char *) stat_string;
> +       const char *z =3D stat_string;
>        if (z =3D=3D NULL)
>                z =3D "";
>        for (int i =3D 0; *z && i < stat_size; i++) {

Ok, I misunderstood you. I thought you mean kind of:
char *z =3D stat_string;

Fixed this point as well.