From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <k.sosnin@tarantool.org>
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0C2E44696C3
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  8 Apr 2020 00:52:32 +0300 (MSK)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\))
From: Chris Sosnin <k.sosnin@tarantool.org>
In-Reply-To: <a49b7127-68dc-06d9-f2d2-1bc10ceb976d@tarantool.org>
Date: Wed, 8 Apr 2020 00:52:31 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <DE16CDF6-F035-4F56-A6F6-CF54AFA63DCE@tarantool.org>
References: <cover.1584110394.git.k.sosnin@tarantool.org>
 <15594780-32ed-abf0-5c39-9b0c7d9438c5@tarantool.org>
 <a49b7127-68dc-06d9-f2d2-1bc10ceb976d@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 0/2] box: fix session.push
 formatting
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

I=E2=80=99ve sent the patch set to Nikita with the following change log:

@ChangeLog
- Add Lua output format support for box.session.push

I thought this will suffice.

> On 7 Apr 2020, at 23:29, Vladislav Shpilevoy =
<v.shpilevoy@tarantool.org> wrote:
>=20
> Hi! I suggest to hurry up, we have the release closer and closer.
>=20
> On 04/04/2020 01:42, Vladislav Shpilevoy wrote:
>> Thanks for the fixes!
>>=20
>> The patchset LGTM. Except that the changelog is still
>> missing.
>>=20
>> Please, add a changelog, and send on a second review.
>> I propose either Nikita or Alexander L.
>>=20
>> On 13/03/2020 15:58, Chris Sosnin wrote:
>>> issue: https://github.com/tarantool/tarantool/issues/4686
>>> branch: =
https://github.com/tarantool/tarantool/tree/ksosnin/gh-4686-session-push-f=
mt
>>>=20
>>> Changes in v2:
>>> - Current format moved to struct session.
>>> - Applied review fixes.
>>>=20
>>> Chris Sosnin (2):
>>>  refactoring: store output format in struct session
>>>  box: fix formatting in session.push
>>>=20
>>> extra/exports                 |  2 +
>>> src/box/lua/console.c         | 53 ++++++++++++++++++--------
>>> src/box/lua/console.lua       | 72 =
+++++++++++++++++++++++++++--------
>>> src/box/session.h             | 22 ++++++++---
>>> test/app-tap/console.test.lua | 14 ++++++-
>>> 5 files changed, 126 insertions(+), 37 deletions(-)
>>>=20