From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <k.sosnin@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AC9F846970E
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 30 Jan 2020 15:53:53 +0300 (MSK)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
From: Chris Sosnin <k.sosnin@tarantool.org>
In-Reply-To: <20200130120412.GD16149@tarantool.org>
Date: Thu, 30 Jan 2020 15:53:51 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <DAAF0227-B68B-447C-8F0A-A2F1E775F7AE@tarantool.org>
References: <20200127140420.52553-1-k.sosnin@tarantool.org>
 <20200130120412.GD16149@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] sql: fix segfault in pragma
 table_info
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thank you for the review!

> I'd add a bit of details:
>=20
> -- Make sure that 'pragma table_info()' correctly handles tables
> -- without primary key.

I agree, inserted your version.

>=20
>> +table_info =3D box.execute('pragma =
table_info("_vinyl_deferred_delete")')
>=20
> To ignore statement result as a rule we use underscore:
>=20
> _ =3D box.execute(=E2=80=A6)

Fixed.

> Finally, personally I wouldn't focus on particular =
'_vinyl_deferred_delete'
> system space, but rather create casual space without pk and/or format =
and
> use it in the test. Then we could run it using both engines.


I rewrote tests, new diff:

+test_run =3D require('test_run').new()
+engine =3D test_run:get_cfg('engine')
+--
+-- Make sure that 'pragma table_info()' correctly handles tables
+-- without primary key.
+--
+T =3D box.schema.create_space('T', {         \
+    engine =3D engine,                       \
+    format =3D {{'i', 'integer'}}            \
+})
+_ =3D box.execute('pragma table_info(T)')
+T:drop()=