From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 91C6D2682C for ; Tue, 5 Feb 2019 08:42:48 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0a9lDdvym2IH for ; Tue, 5 Feb 2019 08:42:48 -0500 (EST) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id BCE3124E7D for ; Tue, 5 Feb 2019 08:42:47 -0500 (EST) From: "n.pettik" Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_4F45C7ED-4B0C-4531-A34D-45702851FB3A" Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: [tarantool-patches] Re: [PATCH] sql: remove tests on ORDER BY/LIMIT + DELETE Date: Tue, 5 Feb 2019 16:42:44 +0300 In-Reply-To: <02101d10-cf70-d974-ee0b-0f66166c73ca@tarantool.org> References: <20190204153458.12559-1-ivan.koptelov@tarantool.org> <02101d10-cf70-d974-ee0b-0f66166c73ca@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Ivan Koptelov --Apple-Mail=_4F45C7ED-4B0C-4531-A34D-45702851FB3A Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 4 Feb 2019, at 22:11, Ivan Koptelov = wrote: >>> On 4 Feb 2019, at 18:34, Ivan Koptelov = wrote: >>>=20 >>> Removes obsolete tests on ORDER BY/LIMIT + DELETE. This >>> functionality was not supported for some time, but a few tests >>> were still existing. >>>=20 >>> Closes #2172 >>> --- >>> Branch = https://github.com/tarantool/tarantool/compare/sudobobo/gh-2172-rm-order-b= y-and-limit-from-delete = >>> Issue https://github.com/tarantool/tarantool/issues/2172 = >>>=20 >>> test/sql-tap/e_delete.test.lua | 188 = ----------------------------------------- >>> 1 file changed, 188 deletions(-) >>>=20 >>> diff --git a/test/sql-tap/e_delete.test.lua = b/test/sql-tap/e_delete.test.lua >>> index 84a4e0a22..0a81eb3bd 100755 >>> --- a/test/sql-tap/e_delete.test.lua >>> +++ b/test/sql-tap/e_delete.test.lua >>> @@ -305,194 +305,6 @@ if (0 > 0) then >>> DELETE FROM t8 NOT INDEXED WHERE a=3D5; >>> END;]], {"NOT INDEXED"}}, >>> }) >>> - -- EVIDENCE-OF: R-64942-06615 The LIMIT and ORDER BY clauses = (described >>> - -- below) are unsupported for DELETE statements within = triggers. >>> - =E2=80=94 >> If I=E2=80=99m not mistaken, tests starting from e_delete-2.0 are = disabled >> (under if 0 > 0). So you can delete even more tests. > I thought we could enable this tests later? Could you please examine those tests. If they are valid, simply = uncomment them. If not so - remove. Do it in a separate patch/commit pls. >> Also, check SQLITE_ENABLE_UPDATE_DELETE_LIMIT define: >> I guess it is related to this patch. Seems that it is turned off, so = I >> assume we can delete it alongside with code under it. =20 > Yes, it turned off currently, but it may be turned on. This option = also enables > UPDATE + LIMIT/ORDER BY statements and all code under 'define' = appplies > to this functionality as well, so firstly I decided not to delete it.=20= I really doubt that some day we will do it. LIMIT is non-ansi extension. For example Oracle doesn=E2=80=99t support it at all. I guess this is a = reason why we got rid of delete+limit. Lets remove it as well. --Apple-Mail=_4F45C7ED-4B0C-4531-A34D-45702851FB3A Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 4 Feb 2019, at 22:11, Ivan Koptelov <ivan.koptelov@tarantool.org> wrote:
On 4 Feb 2019, at 18:34, Ivan Koptelov =
<ivan.koptelov@tarantool.or=
g> wrote:

Removes obsolete tests on ORDER BY/LIMIT + DELETE. This
functionality was not supported for some time, but a few tests
were still existing.

Closes #2172
---
Branch https://github.com/tarantool/tarantool/co=
mpare/sudobobo/gh-2172-rm-order-by-and-limit-from-delete
Issue https://github=
.com/tarantool/tarantool/issues/2172

test/sql-tap/e_delete.test.lua | 188 =
-----------------------------------------
1 file changed, 188 deletions(-)

diff --git a/test/sql-tap/e_delete.test.lua =
b/test/sql-tap/e_delete.test.lua
index 84a4e0a22..0a81eb3bd 100755
--- a/test/sql-tap/e_delete.test.lua
+++ b/test/sql-tap/e_delete.test.lua
@@ -305,194 +305,6 @@ if (0 > 0) then
         DELETE FROM t8 NOT INDEXED WHERE a=3D5;
       END;]], {"NOT INDEXED"}},
    })
-    -- EVIDENCE-OF: R-64942-06615 The LIMIT and ORDER BY clauses =
(described
-    -- below) are unsupported for DELETE statements within triggers.
-    =E2=80=94

If I=E2=80=99m =
not mistaken, tests starting from e_delete-2.0 are disabled
(under if 0 > 0). So you can delete even more =
tests.
I thought we = could enable this tests later?

Could you = please examine those tests. If they are valid, simply uncomment = them.
If not so - remove. Do it in a separate patch/commit = pls.
Also, check =
SQLITE_ENABLE_UPDATE_DELETE_LIMIT define:
I guess it is related to this patch. Seems that it is turned off, so I
assume we can delete it alongside with code under it. =20
Yes, it turned off currently, but it = may be turned on. This option also enables
UPDATE + LIMIT/ORDER BY statements = and all code under 'define' appplies
to this functionality as well, so = firstly I decided not to delete it. 

I really doubt that some day we will do it. LIMIT = is non-ansi extension.
For example Oracle doesn=E2=80=99t = support it at all. I guess this is a reason
why we got rid of = delete+limit. Lets remove it as well.

= --Apple-Mail=_4F45C7ED-4B0C-4531-A34D-45702851FB3A--