From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 8584227B08 for ; Thu, 29 Mar 2018 07:28:27 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DwP2mMhS-8SG for ; Thu, 29 Mar 2018 07:28:27 -0400 (EDT) Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [94.100.177.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3D47B27A89 for ; Thu, 29 Mar 2018 07:28:26 -0400 (EDT) Content-Type: multipart/alternative; boundary="Apple-Mail=_F26C23AE-D921-4AFD-A07C-0ACA1DFC25D7" Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [patches] [PATCH V2] sql: fix non-working 'INDEXED BY' clause From: "n.pettik" In-Reply-To: <1522321769.412201095@f369.i.mail.ru> Date: Thu, 29 Mar 2018 14:28:23 +0300 Message-Id: References: <20180312112113.10328-1-niatshin@tarantool.org> <9C7DC5C4-22A8-4F38-8E6A-FACF21115BF2@tarantool.org> <1522321769.412201095@f369.i.mail.ru> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Bulat Niatshin Cc: tarantool-patches@freelists.org --Apple-Mail=_F26C23AE-D921-4AFD-A07C-0ACA1DFC25D7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Ack. > On 29 Mar 2018, at 14:09, Bulat Niatshin = wrote: >=20 > 1. You don=E2=80=99t need to invent own wheel: sql-tap = already > has test:do_eqp_test() function. >=20 > Done. >=20 >=20 > 2. Why did you divide tests and put them to different = test suits? > > test/sql/gh2966-indexed-by.test.lua > > test/sql-tap/gh-2996-indexed-by.test.lua > Put them both to one file to sql-tap/ . >=20 > Done. >=20 > Branch: = https://github.com/tarantool/tarantool/tree/bn/gh-2996-indexed-by = =20 --Apple-Mail=_F26C23AE-D921-4AFD-A07C-0ACA1DFC25D7 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Ack.

On 29 Mar 2018, at 14:09, Bulat = Niatshin <niatshin@tarantool.org> wrote:

= 1. You don=E2=80=99t need to invent own = wheel: sql-tap already
= has test:do_eqp_test() function.

Done.

= 2. Why did you divide tests and put them to different test = suits?
= > test/sql/gh2966-indexed-by.test.lua
= > = test/sql-tap/gh-2996-indexed-by.test.lua
= Put them both to one = file to sql-tap/ .

Done.

Branch: https://github.com/tarantool/tarantool/tree/bn/gh-2996-indexed-= by

= --Apple-Mail=_F26C23AE-D921-4AFD-A07C-0ACA1DFC25D7--