From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1D41321B0A
	for <tarantool-patches@freelists.org>; Tue, 26 Jun 2018 11:17:48 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id KPUUlEknllOM for <tarantool-patches@freelists.org>;
	Tue, 26 Jun 2018 11:17:48 -0400 (EDT)
Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C981B21A37
	for <tarantool-patches@freelists.org>; Tue, 26 Jun 2018 11:17:47 -0400 (EDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: [tarantool-patches] Re: [PATCH] sql: remove sqlite_ functions from
 SQL
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <bc5989f28ac98fbae1a22172915d49f2c9cb5def.1530020544.git.kyukhin@tarantool.org>
Date: Tue, 26 Jun 2018 18:17:44 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <D7CF54A0-A769-4DA9-999D-A26398A2FDEE@tarantool.org>
References: <bc5989f28ac98fbae1a22172915d49f2c9cb5def.1530020544.git.kyukhin@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Kirill Yukhin <kyukhin@tarantool.org>


> On 26 Jun 2018, at 16:33, Kirill Yukhin <kyukhin@tarantool.org> wrote:
>=20
> Branch: =
https://github.com/tarantool/tarantool/tree/kyukhin/gh-2184-remove-version=

> Issue: https://github.com/tarantool/tarantool/issues/2184
>=20
> Removed legacy functions: sqlite_version, sqlite_sourceid,
> sqlite_log. Added version built-in function which returns
> Tarantool's version.
>=20
> Closes #2184
> =E2=80=94

Please, put links to the branch and issue here (after =E2=80=98- - =
-=E2=80=98).

Also, I have found one mention of sqlite_version():

File: resolve.c, line: 709

/* Date/time functions that use 'now', and other functions like
 * sqlite_version() that might change over time cannot be used
 * in an index.
 */

Lets remove it as well.

Except for this, LGTM.