From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3C22928704 for ; Fri, 9 Aug 2019 14:05:28 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eFBa_wt64ySz for ; Fri, 9 Aug 2019 14:05:28 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E5FC728703 for ; Fri, 9 Aug 2019 14:05:27 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [tarantool-patches] Re: [PATCH v2 3/8] sql: wrap all trim functions in dispatcher From: "n.pettik" In-Reply-To: <74a116ac889583f76d8617d644f6277073f9fbdd.1565275469.git.kshcherbatov@tarantool.org> Date: Fri, 9 Aug 2019 21:05:25 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <74a116ac889583f76d8617d644f6277073f9fbdd.1565275469.git.kshcherbatov@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Kirill Shcherbatov > On 8 Aug 2019, at 17:50, Kirill Shcherbatov = wrote: >=20 > A new dispatcher function trim_func calls corresponding trim_ > function implementation in relation with number of argc - a count > of arguments. >=20 > This is an important stem to get rid of function's name Nit: stem -> step > overloading required for replace FuncDef cache with Tarantool's > function cache. >=20 > Needed for #2200, #4113, #2233 > --- > src/box/sql/func.c | 32 +++++++++++++++++++++++++++++--- > 1 file changed, 29 insertions(+), 3 deletions(-) >=20 > diff --git a/src/box/sql/func.c b/src/box/sql/func.c > index e00764c3f..f9c0a819e 100644 > --- a/src/box/sql/func.c > +++ b/src/box/sql/func.c > @@ -1496,6 +1496,32 @@ trim_func_three_args(struct sql_context = *context, int argc, sql_value **argv) > char_cnt, input_str, input_str_sz); > sql_free(char_len); > } > + > +/** > + * Normalize args from @a argv input array when it has one, > + * two or three args. > + * > + * This is a dispatcher function that call corresponding Nit: call -> calls > + * implementation depending on the number of arguments. > +*/ > +static void > +trim_func(struct sql_context *context, int argc, sql_value **argv) > +{ > + switch (argc) { > + case 1: > + trim_func_one_arg(context, argc, argv); Why not unpack arguments right here? IMHO it would look much better.