From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4F83120D3A for ; Mon, 15 Jul 2019 10:42:07 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KVxtWg3XZ_AC for ; Mon, 15 Jul 2019 10:42:07 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0CC5120B2D for ; Mon, 15 Jul 2019 10:42:06 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: return lookaside system From: "n.pettik" In-Reply-To: <83b139b9-4268-4f21-c27b-13a2f2da77f3@tarantool.org> Date: Mon, 15 Jul 2019 17:42:04 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <582dfdcffb17a62d2f2de1f5d7f95220c07eda62.1562408568.git.imeevma@gmail.com> <83b139b9-4268-4f21-c27b-13a2f2da77f3@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Imeev Mergen > On 9 Jul 2019, at 12:03, Imeev Mergen wrote: >=20 > Hi! Thank you for review. My answer below. >=20 > On 7/8/19 4:13 PM, n.pettik wrote: >>=20 >>> On 6 Jul 2019, at 13:23, imeevma@tarantool.org wrote: >>>=20 >>> After the removal of the LOOKASIDE system, it was found that the >>> performance dropped. To restore performance, this patch partially >>> returns the LOOKASIDE system in almost the same form as it was >>> before the patch 4326ca7. >>>=20 >>> Closes #4319 >> Have you verified that performance is restored by these changes? >>=20 > I asked @avtikhon to check this before sending the patch. He > checked that the performance was restored. Should I copy here the > tables that he sent me? I=E2=80=99m ok with this patch. But just in case I would test it with = asan/valgrind (if they are still functioning with Tarantool=E2=80=99s test suite).=