From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <k.sosnin@tarantool.org>
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1CDE5469719
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 22 Feb 2020 19:43:13 +0300 (MSK)
From: Chris Sosnin <k.sosnin@tarantool.org>
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
Date: Sat, 22 Feb 2020 19:43:12 +0300
References: <20200221123203.6956-1-k.sosnin@tarantool.org>
 <df82a30f-6a15-9e08-ef58-c0879be604d5@tarantool.org>
In-Reply-To: <df82a30f-6a15-9e08-ef58-c0879be604d5@tarantool.org>
Message-Id: <D014D90B-8FB2-4CF6-8351-9C58363D1C17@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] app: verify unix socket path length
 in socket.tcp_server()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org

Hi! Thank you for the review!

> 22 =D1=84=D0=B5=D0=B2=D1=80. 2020 =D0=B3., =D0=B2 19:28, Vladislav =
Shpilevoy <v.shpilevoy@tarantool.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=
=D0=BB(=D0=B0):
>=20
> Hi! Thanks for the patch!
>=20
>> diff --git a/test/app/socket.result b/test/app/socket.result
>> index 9829df138..f47d06935 100644
>> --- a/test/app/socket.result
>> +++ b/test/app/socket.result
>> @@ -1614,6 +1614,14 @@ socket.getaddrinfo('host', 'port', { flags =3D =
'WRONG' }) =3D=3D nil and errno() =3D=3D er
>> ---
>> - true
>> ...
>> +-- gh-4634: verify socket path length in socket.tcp_server.
>> +long_port =3D string.rep('a', 110)
>> +---
>> +...
>> +socket.tcp_server('unix/', long_port, function(s) end) =3D=3D =
errno.ENOBUF
>=20
> Both function result and errno.ENOBUF are nil. No wonder they are =
equal.

I=E2=80=99m sorry, I was very careless. The fix is pushed:

+-- gh-4634: verify socket path length in socket.tcp_server.
+long_port =3D string.rep('a', 110)
+socket.tcp_server('unix/', long_port, function(s) end) =3D=3D nil and =
errno() =3D=3D errno.ENOBUFS=