From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Serge Petrenko Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_CEFD19AF-B12A-4823-8E70-9D6D06BA45C9" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: Re: [tarantool-patches] Re: [PATCH v4 0/2] memtx: add yields during index build Date: Thu, 30 May 2019 16:41:14 +0300 In-Reply-To: <20190530133811.svuqpxoinhyqtbtc@esperanza> References: <20190530133811.svuqpxoinhyqtbtc@esperanza> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: --Apple-Mail=_CEFD19AF-B12A-4823-8E70-9D6D06BA45C9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > 30 =D0=BC=D0=B0=D1=8F 2019 =D0=B3., =D0=B2 16:38, Vladimir Davydov = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0= ): >=20 > On Thu, May 30, 2019 at 03:13:26PM +0300, Serge Petrenko wrote: >> This patchset makes memtx engine yield during index build, which = prevents it >> from stalling the event loop, and moves appropriate test cases from = vinyl suite, >> where such a feature was implemented earlier, to engine suite. >>=20 >> The first patch introduces changes in index build mechanism >> The second patch adds necessary tests >>=20 >> Changes in v4: >> - move errinj introduction to the >> second patch >> - move more tests from vinyl/errinj_ddl >> to engine/errinj_ddl >> - unify errinjs in memtx and vinyl index >> build for easier testing >> - ref count cursor before yield in index >> build >>=20 >> Changes in v3: >> - split the patch into two, >> the second one moving appropriate >> tests from vinyl to engine suite >> - add a docbot request to the >> first patch >> - ensure index unique constraints >> are checked in on_replace triggers >> - fix tuple comparsion in on_replace >> triggers >>=20 >> Changes in v2: >> - add an on_replace trigger >> to handle concurrent replaces >> while index build yields >> - modify test case slightly, >> test concurrent replaces. >>=20 >> Serge Petrenko (2): >> memtx: add yields during index build >> test: move background index build test to engine suite from vinyl >=20 > Pushed to master. Thanks for addressing all my comments. >=20 > We should probably make format check yielding, too. This should be > very similar to what you've just done. Please consider doing this in > a follow-up patch. Ok, will do. Thank you --Apple-Mail=_CEFD19AF-B12A-4823-8E70-9D6D06BA45C9 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

30 =D0=BC=D0=B0=D1=8F 2019 =D0=B3., =D0=B2 16:38, Vladimir = Davydov <vdavydov.dev@gmail.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0= =B0=D0=BB(=D0=B0):

On Thu, May = 30, 2019 at 03:13:26PM +0300, Serge Petrenko wrote:
This = patchset makes memtx engine yield during index build, which prevents = it
from stalling the event loop, and moves appropriate = test cases from vinyl suite,
where such a feature was = implemented earlier, to engine suite.

The = first patch introduces changes in index build mechanism
The = second patch adds necessary tests

Changes = in v4:
 - move errinj introduction to the
   second patch
 - move = more tests from vinyl/errinj_ddl
   to = engine/errinj_ddl
 - unify errinjs in memtx and vinyl = index
   build for easier testing
 - ref count cursor before yield in index
   build

Changes = in v3:
- split the patch into two,
  the second one moving appropriate
  tests from vinyl to engine suite
- = add a docbot request to the
  first patch
- ensure index unique constraints
  are= checked in on_replace triggers
- fix tuple comparsion in = on_replace
  triggers

Changes in v2:
- add an on_replace trigger
  to handle concurrent replaces
  while index build yields
- modify = test case slightly,
  test concurrent = replaces.

Serge Petrenko (2):
 memtx: add yields during index build
 test: move background index build test to engine suite = from vinyl

Pushed to master. Thanks for addressing all my = comments.

We should = probably make format check yielding, too. This should be
very similar to what you've just = done. Please consider doing this in
a follow-up patch.

Ok, will do. Thank you

= --Apple-Mail=_CEFD19AF-B12A-4823-8E70-9D6D06BA45C9--