From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <inthrax@gmail.com>
Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com
 [209.85.208.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 86D1A4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 15 Apr 2020 13:40:54 +0300 (MSK)
Received: by mail-ed1-f66.google.com with SMTP id w4so4011092edv.13
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 15 Apr 2020 03:40:54 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1586650013.git.v.shpilevoy@tarantool.org>
 <20200412113423.GA28681@atlas>
 <84069240-b5a4-9e61-09f4-a347fe53d54c@tarantool.org>
 <20200413094004.GB16266@atlas> <20200413094230.GC16266@atlas>
 <533bd68c-4bbb-446a-6265-da4f47d451f1@tarantool.org>
 <20200413194931.GB1734@tarantool.org>
 <8b7bcee8-b2db-8f2c-d241-687f6b6d6f4b@tarantool.org>
 <20200413213801.GB12552@atlas>
 <13d501d61286$af32d4b0$0d987e10$@tarantool.org> <20200414204127.GA32171@atlas>
In-Reply-To: <20200414204127.GA32171@atlas>
From: Mons Anderson <mons@cpan.org>
Date: Wed, 15 Apr 2020 13:40:42 +0300
Message-ID: <CAOgz_5-oGRRPMU2a_hvOOO=Z3p3_tdNF5+avn9TKywBVpweGeA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Tarantool-patches] [PATCH 00/43] Unhide symbols
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, tarantool-patches@dev.tarantool.org

On Tue, Apr 14, 2020 at 11:41 PM Konstantin Osipov
<kostja.osipov@gmail.com> wrote:
>
> * Timur Safin <tsafin@tarantool.org> [20/04/14 21:01]:
> > : Mons will be happy simply if we switch back to default gcc linking
> > : options, -fvisibility=3Ddefault, which is basically dropping
> > : -exported_symbols_list.

We've been discussing this with team. It is sufficient for me.
But you can't just drop exported_symbols_list without replacing it
with something else to guarantee presence of internal ffi functions

>
> This is unrelated. 1.5 didn't have plugin api and no ffi exports
> and mons was hacking into it.
>
> In fact he wasn't hacking into functions at all, he was hacking
> into global state, such as cord_ptr->fiber, and it was not (and I
> believe is not) removed from the visibility list by linker.
>
> In short:
> When trying to understand how this "feature" worked before, look
> at 1.5, not 1.6+.

You are wrong. It works in 1.6 and was broken by mejedi in the middle
of 1.7 and unfortunately left unseen
For ex, I=E2=80=99m using in 1.6:

ffi.cdef[[ uint32_t sc_version; ]]

Things like that stop working after that patch.


--=20
Best wishes,
Vladimir V. Perepelitsa aka Mons Anderson
<inthrax@gmail.com>, <mons@cpan.org>
http://github.com/Mons