From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com
 [209.85.128.68])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 519AF469710
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  9 Jun 2020 11:19:25 +0300 (MSK)
Received: by mail-wm1-f68.google.com with SMTP id r15so2143376wmh.5
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 09 Jun 2020 01:19:25 -0700 (PDT)
MIME-Version: 1.0
References: <cover.1591313754.git.v.shpilevoy@tarantool.org>
In-Reply-To: <cover.1591313754.git.v.shpilevoy@tarantool.org>
From: Cyrill Gorcunov <gorcunov@gmail.com>
Date: Tue, 9 Jun 2020 11:19:11 +0300
Message-ID: <CAM5jBj7PAydT8Vdx83A-_ce5_enyz-s0onYwGxaKjV8vEhrj0g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [Tarantool-patches] [PATCH 00/11] Enable miscelaneous
	sanitations
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

lgtm

On Fri, Jun 5, 2020 at 2:43 AM Vladislav Shpilevoy
<v.shpilevoy@tarantool.org> wrote:
>
> The patchset is a second part of the undefined behaviour fixes. It
> is based on the UB alignment patchset, and enables all the other
> UB checks except a few last ones, described in the first commit.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4609-sanitize-misc-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4609
>
> Aleksandr Lyapunov (1):
>   salad: fix UB pointer arithmetics in bps_tree
>
> Vladislav Shpilevoy (10):
>   cmake: enable misc types of UB detection in clang
>   util: introduce double_compare_nint64()
>   test: avoid usleep() usage for error injections
>   vinyl: fix 0 division in case of canceled dump
>   xrow: don't cast double to float unconditionally
>   swim: fix zero division
>   test: fix signed integer overflow in vclock test
>   digest: eliminate UBs from guava()
>   sql: fix usage of not initialized index_stat
>   sql: fix mem_apply_type double type truncation
>
>  cmake/compiler.cmake        | 16 ++++++++++++++-
>  src/box/sql/vdbe.c          | 18 +++++++++++------
>  src/box/sql/vdbeaux.c       | 16 +++++++--------
>  src/box/sql/where.c         |  4 ++--
>  src/box/tuple_compare.cc    |  9 ++-------
>  src/box/vy_regulator.c      | 10 ++++++----
>  src/box/vy_run.c            |  2 +-
>  src/box/vy_scheduler.c      |  2 +-
>  src/box/xrow_update_field.c | 19 +++++++++---------
>  src/lib/core/util.c         | 39 ++++++++++++++++++++++++++++++++++++-
>  src/lib/salad/bps_tree.h    | 14 ++++++-------
>  src/lib/salad/guava.c       | 18 ++++++++++-------
>  src/lib/salad/guava.h       |  2 +-
>  src/lib/swim/swim.c         | 10 +++++-----
>  src/lua/digest.lua          |  2 +-
>  src/trivia/util.h           | 29 +++++++++++++++++++++++++++
>  test/app/digest.result      |  2 +-
>  test/box/update.result      |  2 +-
>  test/box/update.test.lua    |  2 +-
>  test/unit/vclock.cc         | 28 +++++++++++++-------------
>  test/unit/vclock.result     |  2 +-
>  21 files changed, 167 insertions(+), 79 deletions(-)
>
> --
> 2.21.1 (Apple Git-122.3)
>