From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2044F469710 for ; Thu, 19 Nov 2020 23:52:49 +0300 (MSK) Received: by mail-oo1-f49.google.com with SMTP id f8so1696222oou.0 for ; Thu, 19 Nov 2020 12:52:48 -0800 (PST) MIME-Version: 1.0 References: <20201113145648.268768-1-gorcunov@gmail.com> <20201119120511.GR2021@grain> In-Reply-To: <20201119120511.GR2021@grain> From: Cyrill Gorcunov Date: Thu, 19 Nov 2020 23:52:33 +0300 Message-ID: Content-Type: multipart/alternative; boundary="0000000000000298f305b47be9e2" Subject: Re: [Tarantool-patches] [PATCH] console: drop unused serpent module List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Bronnikov Cc: tml , Alexander Turenko --0000000000000298f305b47be9e2 Content-Type: text/plain; charset="UTF-8" Wait, Sergey, I dropped it already or you mean something else? (Sorry for toppost) @@ -29,7 +29,6 @@ include_files = { exclude_files = { "build/**/*.lua", -- Third-party source code. - "src/box/lua/serpent.lua", "test-run/**/*.lua", "test/**/*.lua", "third_party/**/*.lua", On Thu, Nov 19, 2020 at 3:05 PM Cyrill Gorcunov wrote: > On Thu, Nov 19, 2020 at 02:55:14PM +0300, Sergey Bronnikov wrote: > > Hi, Cyrill! > > > > thanks for the patch! I propose to get rid of exclude for serpent in > > .luacheckrc too. > > Yeah, need to drop it from there as well, I'll update, thanks! > --0000000000000298f305b47be9e2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Wait, Sergey, I dropped it already or you= mean something else?
(Sorry for toppost)

@@ -= 29,7 +29,6 @@ include_files =3D {
=C2=A0exclude_files =3D {
=C2=A0 = =C2=A0 =C2=A0"build/**/*.lua",
=C2=A0 =C2=A0 =C2=A0-- Third-pa= rty source code.
-=C2=A0 =C2=A0 "src/box/lua/serpent.lua",
= =C2=A0 =C2=A0 =C2=A0"test-run/**/*.lua",
=C2=A0 =C2=A0 =C2=A0&= quot;test/**/*.lua",
=C2=A0 =C2=A0 =C2=A0"third_party/**/*.lua= ",

On Thu, Nov 19, 2020 at 3:05 PM Cyrill Gorcunov <gorcunov@gmail.com> wrote:
=
On Thu, Nov 19, 2020 at 0= 2:55:14PM +0300, Sergey Bronnikov wrote:
> Hi, Cyrill!
>
> thanks for the patch! I propose to get rid of exclude for serpent in > .luacheckrc too.

Yeah, need to drop it from there as well, I'll update, thanks!
--0000000000000298f305b47be9e2--