From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9C03E469710 for ; Wed, 10 Jun 2020 11:24:24 +0300 (MSK) Received: by mail-ot1-f66.google.com with SMTP id n70so1061130ota.5 for ; Wed, 10 Jun 2020 01:24:24 -0700 (PDT) MIME-Version: 1.0 References: <20200526151747.93659-1-huston.mavr@gmail.com> <20200609163330.j6iqddyjwbl2ctv2@tkn_work_nb> In-Reply-To: <20200609163330.j6iqddyjwbl2ctv2@tkn_work_nb> From: Mavr Huston Date: Wed, 10 Jun 2020 11:24:14 +0300 Message-ID: Content-Type: multipart/alternative; boundary="00000000000020ee1a05a7b692bf" Subject: Re: [Tarantool-patches] [PATCH] static build: fix build on ubuntu List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org --00000000000020ee1a05a7b692bf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks! @ChangeLog - Fixed static-build on ubuntu (gh-5024) =D0=B2=D1=82, 9 =D0=B8=D1=8E=D0=BD. 2020 =D0=B3. =D0=B2 19:33, Alexander Tu= renko < alexander.turenko@tarantool.org>: > LGTM. > > I didn't verify it manually, but the change itself looks reasonable and > CI pass (except flaky tests and known Mac OS X problem on Travis-CI). > > Sergey, can you look into the proposed change too? > > Alexander (Tikhonov), we added a CI job to verify such things within > [1]. Can you, please, look how it appears that the job didn't catch the > problem? > > > Issue: https://github.com/tarantool/tarantool/issues/5024 > > Branch: > https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-5024-static-b= uild-ubuntu > > Please, answer with a changelog entry for future release notes. We track > user-visible behaviour changes this way: bugfixes and features. When > there is a fix for some build target or configuration, we mention it > too. > > It is just free form description of changes for a user to be placed on > the [releases page][2]. We highlight with @ChangeLog 'tag' to bring a > mainterner attention. > > Since it is the regression, it would be good to mention, when the > problem appears (`git describe bad_commit` output), in the future > release notes. > > For future patches: add it to a cover letter or under `---` for a > signleton patchset (but do not add to a commit message). > > [1]: https://github.com/tarantool/tarantool/issues/4551 > [2]: https://github.com/tarantool/tarantool/releases > > WBR, Alexander Turenko. > --00000000000020ee1a05a7b692bf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks!

@ChangeLog
=

- Fixed static-build on ubuntu (gh-5024)

=D0=B2=D1=82, 9 =D0=B8=D1=8E=D0=BD. 2020 =D0=B3. =D0=B2 19:33, Alexander= Turenko <alexander.t= urenko@tarantool.org>:
LGTM.

I didn't verify it manually, but the change itself looks reasonable and=
CI pass (except flaky tests and known Mac OS X problem on Travis-CI).

Sergey, can you look into the proposed change too?

Alexander (Tikhonov), we added a CI job to verify such things within
[1]. Can you, please, look how it appears that the job didn't catch the=
problem?

> Issue: https://github.com/tarantool/tarantool= /issues/5024
> Branch: htt= ps://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-5024-static-build-= ubuntu

Please, answer with a changelog entry for future release notes. We track user-visible behaviour changes this way: bugfixes and features. When
there is a fix for some build target or configuration, we mention it
too.

It is just free form description of changes for a user to be placed on
the [releases page][2]. We highlight with @ChangeLog 'tag' to bring= a
mainterner attention.

Since it is the regression, it would be good to mention, when the
problem appears (`git describe bad_commit` output), in the future
release notes.

For future patches: add it to a cover letter or under `---` for a
signleton patchset (but do not add to a commit message).

[1]: https://github.com/tarantool/tarantool/issues= /4551
[2]: https://github.com/tarantool/tarantool/releases<= /a>

WBR, Alexander Turenko.
--00000000000020ee1a05a7b692bf--