From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4B24D42EF5C for ; Mon, 15 Jun 2020 20:28:00 +0300 (MSK) Received: by mail-oi1-f194.google.com with SMTP id d67so16585460oig.6 for ; Mon, 15 Jun 2020 10:28:00 -0700 (PDT) MIME-Version: 1.0 References: <20200611002510.35349-1-huston.mavr@gmail.com> <20200614213451.bf3dadnmqxsozfn6@tkn_work_nb> In-Reply-To: <20200614213451.bf3dadnmqxsozfn6@tkn_work_nb> From: Mavr Huston Date: Mon, 15 Jun 2020 20:27:46 +0300 Message-ID: Content-Type: multipart/alternative; boundary="000000000000726ab205a822bf68" Subject: Re: [Tarantool-patches] [PATCH] cmake: cleanup src/CMakeLists.txt List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy , yaroslav.dynnikov@gmail.com --000000000000726ab205a822bf68 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks! I've marked it as follow up for #2971 at commit message. =D0=BF=D0=BD, 15 =D0=B8=D1=8E=D0=BD. 2020 =D0=B3. =D0=B2 00:35, Alexander T= urenko < alexander.turenko@tarantool.org>: > LGTM. > > Vlad, can you look at the patch? > > WBR, Alexander Turenko. > > On Thu, Jun 11, 2020 at 03:25:10AM +0300, HustonMmmavr wrote: > > Removed definition and initialization of EXPORT_LIST variable at file > > src/CMakeLists.txt. After patch 03790ac551 this variable is unused > > (no reference to this variable after its initialization can be found > > in whole project) and it is only misleading. > > > > Closes #5066 > > I would also mark it as follow up for #2971. > > > --- > > I've builded tarantool before applying this changes and after. > > Then I've checked difference in tarantool binary file symbols with > > nm and diff commands and there was no difference. > > > > Issue: https://github.com/tarantool/tarantool/issues/5066 > > Branch: > https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-5066-delete-u= nusued-export-list > > > > @ChangeLog > > - Cleanup src/CMakeLists.txt (gh-5066) > > This change is not visible for a user, so I would not add a changelog > entry for it. > --000000000000726ab205a822bf68 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks!
I've marked it as follow up for #2971 at co= mmit message.

=D0=BF=D0=BD, 15 =D0=B8=D1=8E=D0=BD. 2020 =D0=B3. =D0=B2 0= 0:35, Alexander Turenko <alexander.turenko@tarantool.org>:
LGTM.

Vlad, can you look at the patch?

WBR, Alexander Turenko.

On Thu, Jun 11, 2020 at 03:25:10AM +0300, HustonMmmavr wrote:
> Removed definition and initialization of EXPORT_LIST variable at file<= br> > src/CMakeLists.txt. After patch 03790ac551 this variable is unused
> (no reference to this variable after its initialization can be found > in whole project) and it is only misleading.
>
> Closes #5066

I would also mark it as follow up for #2971.

> ---
> I've builded tarantool before applying this changes and after.
> Then I've checked difference in tarantool binary file symbols with=
> nm and diff commands and there was no difference.
>
> Issue: https://github.com/tarantool/tarantool= /issues/5066
> Branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-5066-delete= -unusued-export-list
>
> @ChangeLog
> - Cleanup src/CMakeLists.txt (gh-5066)

This change is not visible for a user, so I would not add a changelog
entry for it.
--000000000000726ab205a822bf68--