From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4929E469710 for ; Mon, 8 Jun 2020 15:46:23 +0300 (MSK) Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1jiHAU-0001QL-LH for tarantool-patches@dev.tarantool.org; Mon, 08 Jun 2020 15:46:22 +0300 Received: by mail-lj1-f181.google.com with SMTP id y11so18641991ljm.9 for ; Mon, 08 Jun 2020 05:46:22 -0700 (PDT) MIME-Version: 1.0 References: <20200429122038.53296-1-arkholga@tarantool.org> <20200527160242.akqs35kka34fj2cb@tkn_work_nb> <20200604215103.GK5745@tarantool.org> <20200605065521.i3k3dw7xmsejdysm@tkn_work_nb> In-Reply-To: <20200605065521.i3k3dw7xmsejdysm@tkn_work_nb> From: Yaroslav Dynnikov Date: Mon, 8 Jun 2020 15:46:10 +0300 Message-ID: Content-Type: multipart/alternative; boundary="0000000000008189c505a791ffea" Subject: Re: [Tarantool-patches] [PATCH] core: don't start example instance in postinstall List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org, Yaroslav Dynnikov --0000000000008189c505a791ffea Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi! As a person who "faced the issue for several times across these years" I can only add that that most important is fresh installatoin. As far as I can see, the original patch is enough to solve the problem. So, LGTM. P.S. I won't comment other parts of discussion because they're beyond my understanding of deb scripts. On Fri, 5 Jun 2020 at 09:55, Alexander Turenko < alexander.turenko@tarantool.org> wrote: > > Long story short: comparing both approaches I personally prefer to appl= y > > the one from the origin patch and take some changes you provided below > > (e.g. empty directory handling). > > > > I also Cced Yaroslav as the person who faced the issue "for several > > times across these years". > > I don't mind any of these approaches. I don't know which one would be > better. So I would say that I have no preference for one over another. > > > AFAICS, there are some files left on the system after this "migration" > > that are not tracked by the package. So they are not removed anymore > > even after the package is deinstalled. > > They will not be removed at `apt-get remove`, but will be at `apt-get > purge` as well as everything in /etc/tarantool. See: > > | $ cat debian/tarantool-common.postrm > | #!/bin/sh > | > | set -e > | > | case "$1" in > | purge) > | rm -fr \ > | /etc/tarantool \ > | /var/log/tarantool \ > | /var/run/tarantool \ > | /var/lib/tarantool > | ;; > | esac > | > | #DEBHELPER# > --=20 =D0=A1 =D1=83=D0=B2=D0=B0=D0=B6=D0=B5=D0=BD=D0=B8=D0=B5=D0=BC. =D0=94=D1=8B=D0=BD=D0=BD=D0=B8=D0=BA=D0=BE=D0=B2 =D0=AF=D1=80=D0=BE=D1=81= =D0=BB=D0=B0=D0=B2. --0000000000008189c505a791ffea Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

As a person who "fa= ced the issue for several times across these years" I can only add
that that most important is fresh installatoin. As far as I can see,= the original patch is enough
to solve the pr= oblem. So, LGTM.

P.S. I won't comment other pa= rts of discussion because they're beyond my understanding of deb script= s.


On Fri, 5 Jun 2020 at 09:55, Alexander Turenko <alexander.turenko@tarantool.org= > wrote:
= > Long story short: comparing both approaches I personally prefer to app= ly
> the one from the origin patch and take some changes you provided below=
> (e.g. empty <enabled> directory handling).
>
> I also Cced Yaroslav as the person who faced the issue "for sever= al
> times across these years".

I don't mind any of these approaches. I don't know which one would = be
better. So I would say that I have no preference for one over another.

> AFAICS, there are some files left on the system after this "migra= tion"
> that are not tracked by the package. So they are not removed anymore > even after the package is deinstalled.

They will not be removed at `apt-get remove`, but will be at `apt-get
purge` as well as everything in /etc/tarantool. See:

=C2=A0| $ cat debian/tarantool-common.postrm
=C2=A0| #!/bin/sh
=C2=A0|
=C2=A0| set -e
=C2=A0|
=C2=A0| case "$1" in
=C2=A0|=C2=A0 =C2=A0 =C2=A0purge)
=C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0rm -fr=C2=A0 \
=C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/etc/tarantool \
=C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/var/log/tarantool \=
=C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/var/run/tarantool \=
=C2=A0|=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0/var/lib/tarantool =C2=A0|=C2=A0 =C2=A0 =C2=A0;;
=C2=A0| esac
=C2=A0|
=C2=A0| #DEBHELPER#


--
=D0=A1 =D1=83= =D0=B2=D0=B0=D0=B6=D0=B5=D0=BD=D0=B8=D0=B5=D0=BC.=C2=A0
=D0=94=D1=8B=D0= =BD=D0=BD=D0=B8=D0=BA=D0=BE=D0=B2 =D0=AF=D1=80=D0=BE=D1=81=D0=BB=D0=B0=D0= =B2.
--0000000000008189c505a791ffea--