From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 72BCE42EF5C for ; Thu, 2 Jul 2020 13:46:26 +0300 (MSK) Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1jqwjZ-0003FD-M4 for tarantool-patches@dev.tarantool.org; Thu, 02 Jul 2020 13:46:25 +0300 Received: by mail-lf1-f47.google.com with SMTP id k15so15748544lfc.4 for ; Thu, 02 Jul 2020 03:46:25 -0700 (PDT) MIME-Version: 1.0 References: <20200702095054.367131-1-gorcunov@gmail.com> In-Reply-To: <20200702095054.367131-1-gorcunov@gmail.com> From: Yaroslav Dynnikov Date: Thu, 2 Jul 2020 13:46:14 +0300 Message-ID: Content-Type: multipart/alternative; boundary="000000000000b95a2105a9731edf" Subject: Re: [Tarantool-patches] [PATCH v3 0/3] log: allow json formatter in boottime logger List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov Cc: tml --000000000000b95a2105a9731edf Content-Type: text/plain; charset="UTF-8" Hi! Thank you for the patchset, and thank Oleg for the detailed review! Whole patch set LGTM. Best regards Yaroslav Dynnikov On Thu, 2 Jul 2020 at 12:50, Cyrill Gorcunov wrote: > For some reason we've disabled usage of json formatter in early > logging since the commit 098324556. Lets allow it back. > > v2: > - add early verification of options for cases like > box.cfg{log="syslog:", log_format="json"} > - extend test > > v3: > - pass the whole cfg table into verify_option helper > - use string.startswith helper in verify_format > > branch gorcunov/gh-5121-logger-boot-json-3 > issue https://github.com/tarantool/tarantool/issues/5121 > > Cyrill Gorcunov (3): > core/say: allow to use json in boot logger > lua/log: allow to use json formatter early > test: app-tap/logger -- test json in boottime logger > > src/box/lua/load_cfg.lua | 6 +++--- > src/lib/core/say.c | 7 ++---- > src/lua/log.lua | 42 +++++++++++++++++++++++++++--------- > test/app-tap/logger.test.lua | 19 ++++++++++++---- > 4 files changed, 52 insertions(+), 22 deletions(-) > > -- > 2.26.2 > > --000000000000b95a2105a9731edf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi!

Thank you for the patchs= et, and thank Oleg for the detailed review!
Whole patch set LGTM.=

Best regards
=
Yaroslav Dynnikov


On= Thu, 2 Jul 2020 at 12:50, Cyrill Gorcunov <gorcunov@gmail.com> wrote:
For some reason we've dis= abled usage of json formatter in early
logging since the commit 098324556. Lets allow it back.

v2:
=C2=A0- add early verification of options for cases like
=C2=A0 =C2=A0box.cfg{log=3D"syslog:", log_format=3D"json&quo= t;}
=C2=A0- extend test

v3:
=C2=A0- pass the whole cfg table into verify_option helper
=C2=A0- use string.startswith helper in verify_format

branch gorcunov/gh-5121-logger-boot-json-3
issue https://github.com/tarantool/tarantool/issue= s/5121

Cyrill Gorcunov (3):
=C2=A0 core/say: allow to use json in boot logger
=C2=A0 lua/log: allow to use json formatter early
=C2=A0 test: app-tap/logger -- test json in boottime logger

=C2=A0src/box/lua/load_cfg.lua=C2=A0 =C2=A0 =C2=A0|=C2=A0 6 +++---
=C2=A0src/lib/core/say.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 7 = ++----
=C2=A0src/lua/log.lua=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 42 = +++++++++++++++++++++++++++---------
=C2=A0test/app-tap/logger.test.lua | 19 ++++++++++++----
=C2=A04 files changed, 52 insertions(+), 22 deletions(-)

--
2.26.2

--000000000000b95a2105a9731edf--