From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0087D4696C3 for ; Mon, 13 Apr 2020 15:16:16 +0300 (MSK) Received: by smtp63.i.mail.ru with esmtpa (envelope-from ) id 1jNy0e-0004nh-CY for tarantool-patches@dev.tarantool.org; Mon, 13 Apr 2020 15:16:16 +0300 Received: by mail-lj1-f181.google.com with SMTP id n17so8454043lji.8 for ; Mon, 13 Apr 2020 05:16:16 -0700 (PDT) MIME-Version: 1.0 References: <1b51b2fe1c194719a7a8a74220a954a91c21f2a7.1586412430.git.lvasiliev@tarantool.org> In-Reply-To: From: Yaroslav Dynnikov Date: Mon, 13 Apr 2020 15:16:04 +0300 Message-ID: Content-Type: multipart/alternative; boundary="000000000000bb3b6705a32b0ce6" Subject: Re: [Tarantool-patches] [PATCH v3 2/2] Delete flags which can't be used with tarantoolctl rocks List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: lvasiliev Cc: Yaroslav Dynnikov , tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy --000000000000bb3b6705a32b0ce6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, Leonid. LGTM On Mon, 13 Apr 2020 at 14:59, lvasiliev wrote: > Has been discarded from patchset. > > On 09.04.2020 9:33, Leonid Vasiliev wrote: > > --- > > Added changes according to > https://lists.tarantool.org/pipermail/tarantool-patches/2020-April/015459= .html > > I discussed the transfer of the blacklist to Luaro=D1=81ks with > > Alexander Turenko at the beginning of the assignment and > > was decided that it's overkill since we already have patches specific > for tarantool. > > > > src/luarocks/cmd/help.lua | 5 ----- > > src/luarocks/util.lua | 4 ---- > > 2 files changed, 9 deletions(-) > > > > diff --git a/src/luarocks/cmd/help.lua b/src/luarocks/cmd/help.lua > > index dcc9e35..202fe43 100644 > > --- a/src/luarocks/cmd/help.lua > > +++ b/src/luarocks/cmd/help.lua > > @@ -62,12 +62,7 @@ function help.command(description, commands, command= ) > > (overrides any entries in the config file) > > --only-sources=3D Restrict downloads to paths matching the > > given URL. > > - --lua-dir=3D Which Lua installation to use. > > - --lua-version=3D Which Lua version to use. > > --tree=3D Which tree to operate on. > > - --local Use the tree in the user's home directory. > > - To enable it, see ']]..program..[[ help > path'. > > - --global Use the system tree when `local_by_default= ` > is `true`. > > --verbose Display verbose output of commands execute= d. > > --timeout=3D Timeout on network operations, in second= s. > > 0 means no timeout (wait forever). > > diff --git a/src/luarocks/util.lua b/src/luarocks/util.lua > > index 8ccda27..96d4536 100644 > > --- a/src/luarocks/util.lua > > +++ b/src/luarocks/util.lua > > @@ -101,7 +101,6 @@ local supported_flags =3D { > > ["force"] =3D true, > > ["force-fast"] =3D true, > > ["from"] =3D "", > > - ["global"] =3D true, > > ["help"] =3D true, > > ["home"] =3D true, > > ["homepage"] =3D "\"\"", > > @@ -113,14 +112,11 @@ local supported_flags =3D { > > ["lib"] =3D "", > > ["license"] =3D "\"\"", > > ["list"] =3D true, > > - ["local"] =3D true, > > ["local-tree"] =3D true, > > ["lr-bin"] =3D true, > > ["lr-cpath"] =3D true, > > ["lr-path"] =3D true, > > - ["lua-dir"] =3D "", > > ["lua-version"] =3D "", > > - ["lua-versions"] =3D "", > > ["lua-ver"] =3D true, > > ["lua-incdir"] =3D true, > > ["lua-libdir"] =3D true, > > > --=20 =D0=A1 =D1=83=D0=B2=D0=B0=D0=B6=D0=B5=D0=BD=D0=B8=D0=B5=D0=BC. =D0=94=D1=8B=D0=BD=D0=BD=D0=B8=D0=BA=D0=BE=D0=B2 =D0=AF=D1=80=D0=BE=D1=81= =D0=BB=D0=B0=D0=B2. --000000000000bb3b6705a32b0ce6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi, Leonid.

LGTM

On= Mon, 13 Apr 2020 at 14:59, lvasiliev <lvasiliev@tarantool.org> wrote:
Has been discarded from patchset.

On 09.04.2020 9:33, Leonid Vasiliev wrote:
> ---
> Added changes according to https://lists.tarantool.org/pipermail/tarantool-patches/2020-Ap= ril/015459.html
> I discussed the transfer of the blacklist to Luaro=D1=81ks with
> Alexander Turenko at the beginning of the assignment and
> was decided that it's overkill since we already have patches speci= fic for tarantool.
>
>=C2=A0 =C2=A0src/luarocks/cmd/help.lua | 5 -----
>=C2=A0 =C2=A0src/luarocks/util.lua=C2=A0 =C2=A0 =C2=A0| 4 ----
>=C2=A0 =C2=A02 files changed, 9 deletions(-)
>
> diff --git a/src/luarocks/cmd/help.lua b/src/luarocks/cmd/help.lua
> index dcc9e35..202fe43 100644
> --- a/src/luarocks/cmd/help.lua
> +++ b/src/luarocks/cmd/help.lua
> @@ -62,12 +62,7 @@ function help.command(description, commands, comman= d)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (overrides any entries in the config fil= e)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0--only-sources=3D<url>=C2=A0 =C2=A0Res= trict downloads to paths matching the
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 given URL.
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 --lua-dir=3D<prefix>=C2=A0 =C2=A0 = =C2=A0Which Lua installation to use.
> -=C2=A0 =C2=A0 =C2=A0--lua-version=3D<ver>=C2=A0 =C2=A0 Which Lu= a version to use.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0--tree=3D<tree>=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 Which tree to operate on.
> -=C2=A0 =C2=A0 =C2=A0--local=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 Use the tree in the user's home directory.
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 To enable it, see ']]..program..[[ help pa= th'.
> -=C2=A0 =C2=A0 =C2=A0--global=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0Use the system tree when `local_by_default` is `true`.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0--verbose=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 Display verbose output of commands executed.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0--timeout=3D<seconds>=C2=A0 =C2=A0 Tim= eout on network operations, in seconds.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0 means no timeout (wait forever).
> diff --git a/src/luarocks/util.lua b/src/luarocks/util.lua
> index 8ccda27..96d4536 100644
> --- a/src/luarocks/util.lua
> +++ b/src/luarocks/util.lua
> @@ -101,7 +101,6 @@ local supported_flags =3D {
>=C2=A0 =C2=A0 =C2=A0 ["force"] =3D true,
>=C2=A0 =C2=A0 =C2=A0 ["force-fast"] =3D true,
>=C2=A0 =C2=A0 =C2=A0 ["from"] =3D "<server>",=
> -=C2=A0 =C2=A0["global"] =3D true,
>=C2=A0 =C2=A0 =C2=A0 ["help"] =3D true,
>=C2=A0 =C2=A0 =C2=A0 ["home"] =3D true,
>=C2=A0 =C2=A0 =C2=A0 ["homepage"] =3D "\"<url>= ;\"",
> @@ -113,14 +112,11 @@ local supported_flags =3D {
>=C2=A0 =C2=A0 =C2=A0 ["lib"] =3D "<library>",=
>=C2=A0 =C2=A0 =C2=A0 ["license"] =3D "\"<text>= ;\"",
>=C2=A0 =C2=A0 =C2=A0 ["list"] =3D true,
> -=C2=A0 =C2=A0["local"] =3D true,
>=C2=A0 =C2=A0 =C2=A0 ["local-tree"] =3D true,
>=C2=A0 =C2=A0 =C2=A0 ["lr-bin"] =3D true,
>=C2=A0 =C2=A0 =C2=A0 ["lr-cpath"] =3D true,
>=C2=A0 =C2=A0 =C2=A0 ["lr-path"] =3D true,
> -=C2=A0 =C2=A0["lua-dir"] =3D "<path>",
>=C2=A0 =C2=A0 =C2=A0 ["lua-version"] =3D "<vers>&q= uot;,
> -=C2=A0 =C2=A0["lua-versions"] =3D "<versions>&qu= ot;,
>=C2=A0 =C2=A0 =C2=A0 ["lua-ver"] =3D true,
>=C2=A0 =C2=A0 =C2=A0 ["lua-incdir"] =3D true,
>=C2=A0 =C2=A0 =C2=A0 ["lua-libdir"] =3D true,
>


--
=D0=A1 =D1=83= =D0=B2=D0=B0=D0=B6=D0=B5=D0=BD=D0=B8=D0=B5=D0=BC.=C2=A0
=D0=94=D1=8B=D0= =BD=D0=BD=D0=B8=D0=BA=D0=BE=D0=B2 =D0=AF=D1=80=D0=BE=D1=81=D0=BB=D0=B0=D0= =B2.
--000000000000bb3b6705a32b0ce6--