From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 39D614696C3 for ; Sun, 12 Apr 2020 21:30:57 +0300 (MSK) Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1jNhNg-0007IF-NF for tarantool-patches@dev.tarantool.org; Sun, 12 Apr 2020 21:30:56 +0300 Received: by mail-lf1-f53.google.com with SMTP id f8so4979324lfe.12 for ; Sun, 12 Apr 2020 11:30:56 -0700 (PDT) MIME-Version: 1.0 References: <865fb768-3c90-ec8e-96cf-7d7598a9f6e0@tarantool.org> <711c06ec-7953-fcb0-f0cd-a1b68a37e8ae@tarantool.org> In-Reply-To: From: Yaroslav Dynnikov Date: Sun, 12 Apr 2020 21:30:44 +0300 Message-ID: Content-Type: multipart/alternative; boundary="000000000000d1d35105a31c2a26" Subject: Re: [Tarantool-patches] [PATCH v3 0/2] Adapt luarocks for tarantoolctl List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: lvasiliev Cc: Yaroslav Dynnikov , tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy --000000000000d1d35105a31c2a26 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, guys. Recently we talked to Leonid in chat and discussed the necessity of removing flags. I've offered Leonid to check behavior, so here is what I've found. My point of view (now and then) is that they're neither useful nor harmful. Earlier I did agree to blacklist them, but looking at Leonids patch set this week I've changed my mind as the second commit seems just worthless to me. Inline help says: ``` --lua-dir=3D Which Lua installation to use. --lua-version=3D Which Lua version to use. --global Use the system tree when `local_by_default` is `true`. --local Use the tree in the user's home directory. To enable it, see '/opt/tarantool-install/bin/tarantoolctl help path'. Rocks trees in use: /tmp/tmp.JY1fgy8La9/.rocks ("user") /opt/tarantool-install ("system") ``` * Tarantool does define `LOCAL_BY_DEFAULT =3D true`, (i.e. `--local` is our default behavior) * "System tree" is the place where tarantool is installed (`-DCMAKE_INSTALL_PREFIX`). * "Home directory" in tarantool is overriden with `./.rocks`. * See "rocks: update luarocks to 3.1.1" 4222c1f6 . * Both `--local` and `--global` are only shortcuts for predefined `--tree=3D`, which isn't going to be removed. * Speaking of `--lua-dir` and `--lua-version`, they look to be neither useful nor harmful. Please, notice that command-line help refers to `tarantoolctl help path`, but 1. It should be `tarantoolctl rocks help` (I guess there are many of such places) 2. `rocks path` command is disabled in your patch. I'm a lazy developer and I don't like unnecessary restrictions. If I were you, I'd drop the second commit ("Delete flags which can't be used with tarantoolctl rocks" 1b51b2f) and enable back `rocks path` command. Let people decide whether they need it or not. Finally, a few words about documentation. I've tried to write down all supported commands and flags, and I found it's really difficult and verbose. I'm withdrawing my suggestion to clarify it, I don't know what to do. Perhaps, documentation should just refer to inline help, as it's the only up-to-date information, and still correct enough. On Sun, 12 Apr 2020 at 20:25, lvasiliev wrote: > > > On 11.04.2020 17:23, Vladislav Shpilevoy wrote: > > >> As of the second one ("Delete flags which can't be used with > >> tarantoolctl rocks" 1b51b2f < > https://github.com/tarantool/luarocks/commit/1b51b2fe1c194719a7a8a74220a9= 54a91c21f2a7>), > I'm worried that our fork every day goes > >> farther from upstream. You didn't say a word about necessity to /remov= e/ > >> it, but it looks like another postponed problem. > > > > Leonid, btw, why do we remove them, again? I was always thinking it > > is a part of the ticket, but I don't see it there except in your > > comments. > Because after talking with Yaroslav, we decided that the user should not > be able to use these flags. > When I worked on task, I was still too young and did not know that all > summaries of discussions should be written down in comments on task. > --=20 =D0=A1 =D1=83=D0=B2=D0=B0=D0=B6=D0=B5=D0=BD=D0=B8=D0=B5=D0=BC. =D0=94=D1=8B=D0=BD=D0=BD=D0=B8=D0=BA=D0=BE=D0=B2 =D0=AF=D1=80=D0=BE=D1=81= =D0=BB=D0=B0=D0=B2. --000000000000d1d35105a31c2a26 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi, guys.

Recently we talked to Leonid in chat and = discussed the necessity of
removing flags. I've offered Leonid to ch= eck behavior, so here is what
I've found.

My point of view (n= ow and then) is that they're neither useful nor
harmful. Earlier I d= id agree to blacklist them, but looking at Leonids
patch set this w= eek I've changed my mind as the second commit seems
just wort= hless to me.

Inline help says:

```
--lua-dir=3D<prefix> =C2=A0 =C2=A0 Which Lua install= ation to use.
--lua-version=3D<ver> =C2=A0 =C2=A0Which Lua version= to use.
--global =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Use t= he system tree when `local_by_default` is `true`.
--local =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0Use the tree in the user's hom= e directory.
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0To enable it, see '/opt/tarantool-install/bin/t= arantoolctl help path'.

Rocks trees in use: =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0
=C2=A0 =C2=A0 =C2=A0 =C2=A0 /= tmp/tmp.JY1fgy8La9/.rocks ("user")
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 /opt/tarantool-install ("system") =C2=A0 =C2=A0
```=

* Tarantool does define `LOCAL_BY_DEFAULT =3D true`,
=C2=A0 (i.e= . `--local` is our default behavior)

* "System tree" is th= e place where tarantool is installed
=C2=A0 (`-DCMAKE_INSTALL_PREFIX`).<= br>
* "Home directory" in tarantool is overriden with `./.rock= s`.

* See "rocks: update luarocks to 3.1.1" 4222c1f6.

* Both `--local` and `--gl= obal` are only shortcuts for predefined
=C2=A0 `--tree=3D<tree>`, = which isn't going to be removed.

* Speaking of `--lua-dir` and `= --lua-version`, they look to be neither
=C2=A0 useful nor harmful.
Please, notice that command-line help refers to `tarantoolctl help
pat= h`, but

1. It should be `tarantoolctl rocks help` (I guess there are= many of
=C2=A0 =C2=A0such places)
2. `rocks path` command is disable= d in your patch.

I'm a lazy developer and I don't like unnec= essary restrictions. If I
were you, I'd drop the second commit (&quo= t;Delete flags which can't be used
with tarantoolctl rocks" 1b5= 1b2f) and enable back `rocks path` command.
Let people decide whether th= ey need it or not.

Finally, a few words about documentation. I'v= e tried to write down all
supported commands and flags, and I found it&#= 39;s really difficult and
verbose. I'm withdrawing my suggestion to = clarify it, I don't know what
to do. Perhaps, documentation should j= ust refer to inline help, as it's the
only up-to-date information, a= nd still correct enough.



On Sun, 12 Apr 2020 at 20:25, lvasiliev= <lvasiliev= @tarantool.org> wrote:


On 11.04.2020 17:23, Vladislav Shpilevoy wrote:

>> As of the second one ("Delete flags which can't be used w= ith
>> tarantoolctl rocks" 1b51b2f <https://github.com/tarantool/luarocks/commit= /1b51b2fe1c194719a7a8a74220a954a91c21f2a7>), I'm worried that ou= r fork every day goes
>> farther from upstream. You didn't say a word about necessity t= o /remove/
>> it, but it looks like another postponed problem.
>
> Leonid, btw, why do we remove them, again? I was always thinking it > is a part of the ticket, but I don't see it there except in your > comments.
Because after talking with Yaroslav, we decided that the user should not be able to use these flags.
When I worked on task, I was still too young and did not know that all
summaries of discussions should be written down in comments on task.


--
=D0=A1 =D1=83=D0=B2=D0=B0=D0=B6=D0=B5= =D0=BD=D0=B8=D0=B5=D0=BC.=C2=A0
=D0=94=D1=8B=D0=BD=D0=BD=D0=B8=D0=BA=D0= =BE=D0=B2 =D0=AF=D1=80=D0=BE=D1=81=D0=BB=D0=B0=D0=B2.
--000000000000d1d35105a31c2a26--