From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C8E0624D04 for ; Mon, 16 Jul 2018 14:37:37 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SpsvpYc9AF2v for ; Mon, 16 Jul 2018 14:37:37 -0400 (EDT) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7920524A25 for ; Mon, 16 Jul 2018 14:37:37 -0400 (EDT) Received: by mail-lj1-f175.google.com with SMTP id v9-v6so20494758ljk.4 for ; Mon, 16 Jul 2018 11:37:37 -0700 (PDT) MIME-Version: 1.0 References: <5BB99B27-5F86-4664-AAD5-57A22ECED854@tarantool.org> <93E4DAEA-EF90-479D-9F62-3D1CEB3CBE3F@tarantool.org> <20180628101839.fhnijezdpwviohop@tkn_work_nb> <20180709155006.fwrikbznqk23ger5@tkn_work_nb> <79D03E96-0BD0-418D-9DB2-45318C734628@tarantool.org> In-Reply-To: From: Nikita Tatunov Date: Mon, 16 Jul 2018 21:37:24 +0300 Message-ID: Subject: [tarantool-patches] Re: [PATCH] sql: xfer optimization issue Content-Type: multipart/alternative; boundary="000000000000935e6f0571221f94" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: korablev@tarantool.org Cc: tarantool-patches@freelists.org --000000000000935e6f0571221f94 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Here's diff for the fixed and rebased patch. There're some unexpected things concerned with the check of emptiness of destination table: internals can only correctly deal with ABORT conflict action and also my 'small optimization of optimization' was incorrect. =D0=BF=D0=BD, 16 =D0=B8=D1=8E=D0=BB. 2018 =D0=B3. =D0=B2 16:20, Nikita Tatu= nov : > > =D0=BF=D0=BD, 16 =D0=B8=D1=8E=D0=BB. 2018 =D0=B3. =D0=B2 16:06, n.pettik = : > >> Could you please rebase patch on fresh 2.0? >> After that, I will give final assessment. >> >> > Yes, no problem. > > >> Also, did you manage to check that xfer optimisation really works at >> runtime? >> > > Yes, I have it in newer tests and involved an int variable on this > purpose. Only need to make small fixes in it. > --000000000000935e6f0571221f94 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Here's diff for the fixed and rebased patch. There'= ;re some unexpected things concerned with the check of emptiness of destina= tion table: internals can only correctly deal with ABORT conflict action an= d also my 'small optimization of optimization' was incorrect.
=
=D0=BF=D0=BD, 16 =D0=B8=D1= =8E=D0=BB. 2018 =D0=B3. =D0=B2 16:20, Nikita Tatunov <hollow653@gmail.com>:

=D0=BF=D0=BD, 16 =D0=B8=D1=8E=D0=BB. 2018 =D0=B3. =D0=B2 16:06, n.pett= ik <korablev= @tarantool.org>:
Could you p= lease rebase patch on fresh 2.0?
After that, I will give final assessment.


Yes, no problem.
=C2=A0
Also, did you manage to check that xfer optimisation really works at runtim= e?

Yes, I have it in newer tests and in= volved an int variable on this purpose. Only need to make small fixes in it= .
--000000000000935e6f0571221f94--