From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5335A27D4E for ; Fri, 20 Jul 2018 12:59:01 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vSxygcrf3zKl for ; Fri, 20 Jul 2018 12:59:01 -0400 (EDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id F2E8327D0D for ; Fri, 20 Jul 2018 12:59:00 -0400 (EDT) Received: by mail-lf1-f53.google.com with SMTP id v22-v6so2250532lfe.8 for ; Fri, 20 Jul 2018 09:59:00 -0700 (PDT) MIME-Version: 1.0 References: <5BB99B27-5F86-4664-AAD5-57A22ECED854@tarantool.org> <93E4DAEA-EF90-479D-9F62-3D1CEB3CBE3F@tarantool.org> <20180628101839.fhnijezdpwviohop@tkn_work_nb> <20180709155006.fwrikbznqk23ger5@tkn_work_nb> <79D03E96-0BD0-418D-9DB2-45318C734628@tarantool.org> <8B8D5501-075D-4BEB-B282-35B0B81CD555@tarantool.org> <605B15EF-BD1C-4B03-8A9F-6E6225076812@tarantool.org> <12B62C73-9BEC-49FA-B3FD-590C445CF25B@tarantool.org> <2123605D-8D6C-43A3-846F-735E4C2C7FC2@tarantool.org> In-Reply-To: <2123605D-8D6C-43A3-846F-735E4C2C7FC2@tarantool.org> From: Nikita Tatunov Date: Fri, 20 Jul 2018 19:58:48 +0300 Message-ID: Subject: [tarantool-patches] Re: [PATCH] sql: xfer optimization issue Content-Type: multipart/alternative; boundary="00000000000048db2b05717136e1" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: korablev@tarantool.org Cc: tarantool-patches@freelists.org --00000000000048db2b05717136e1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ooops. Thank you! fixed it and pushed. =D0=BF=D1=82, 20 =D0=B8=D1=8E=D0=BB. 2018 =D0=B3. =D0=B2 19:43, n.pettik : > LGTM. > > diff --git a/src/box/sql/insert.c b/src/box/sql/insert.c > index 3c3bf37..4f52fa5 100644 > --- a/src/box/sql/insert.c > +++ b/src/box/sql/insert.c > @@ -1869,7 +1869,7 @@ xferOptimization(Parse * pParse, /* Parser context > */ > * table (tab1) is initially empty. > */ > > - /* The Vdbe we're building*/ > + /* The Vdbe struct we're building. */ > > > You misunderstood me. What I mean is: > > struct Vibe *v =3D =E2=80=A6; > > Vdbe *v =3D sqlite3GetVdbe(pParse); > > > --00000000000048db2b05717136e1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ooops. Thank you! fixed it and pushed.

=D0=BF=D1=82, 20 =D0=B8=D1=8E=D0=BB. 2018= =D0=B3. =D0=B2 19:43, n.pettik <korablev@tarantool.org>:
=
LGTM.

diff --git a/s= rc/box/sql/insert.c b/src/box/sql/insert.c
index 3c3bf37..4f52fa5= 100644
--- a/src/box/sql/insert.c
+++ b/src/box/sql/in= sert.c
@@ -1869,7 +1869,7 @@ xferOptimization(Parse * pParse, /* Parser context */
=C2= =A0 =C2=A0* table (tab1) is initially e= mpty.
=C2=A0 =C2=A0*/
=C2=A0
- /* The Vd= be we're building*/
+ /* The Vdbe struct we're building. */

You misunderstood me. What I mean is:

struct Vibe *v =3D =E2=80=A6;

=C2=A0 Vdbe *v =3D sqlite3GetVdbe(pParse);

--00000000000048db2b05717136e1--