From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B050C6F3C7; Fri, 26 Mar 2021 14:26:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B050C6F3C7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616757977; bh=qJGqgxu/9QbgbOXtJFP8pj4vM78GfhJiI2Sx3MqOmXY=; h=In-Reply-To:Date:References:To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=oDeVT4pF3L2FY0wN5THfHXaKI85RdYeH4x3E5QkazUlq8HtZCBeHXb5ptO4WlIYB0 x/gDpG/LXUlVudxdhu61rBdVtNrfjLvEeWknfB6Ez1Yeyr5GSfKi2IlNJHKp0SE0Ob GZ3m7drH7wvQCfy3CkyxF0zsKN5IMIsr1Q87wuj8= Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A825B6F3C7 for ; Fri, 26 Mar 2021 14:26:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A825B6F3C7 Received: by smtp46.i.mail.ru with esmtpa (envelope-from ) id 1lPkbW-0003IR-TB; Fri, 26 Mar 2021 14:26:15 +0300 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) In-Reply-To: <05d8289981e0933402c01659b6785a309d289036.1616743343.git.skaplun@tarantool.org> Date: Fri, 26 Mar 2021 14:26:13 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: References: <05d8289981e0933402c01659b6785a309d289036.1616743343.git.skaplun@tarantool.org> To: Sergey Kaplun X-Mailer: Apple Mail (2.3654.60.0.2.21) X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9064ADF4728AA0EE993662DB34D9B1ABD5A9410DDDE83AB43182A05F53808504091F85ECC950F2C9803B7A26FBECB4A826BC2A1743A191AB04D186508A6079788 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378D08D652E28591A78638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5D49058A69FB02AAB55E93741B6577CB7EA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3A12191B5F2BB8629117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73589424AA0EF8DE9BAC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A50ED9A47834DC82F703B1F6050170219EA69869260FA88454D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343D1F112031EF3D62854D28C5B8431BDD0C85BED8D8CB96D5B216BECD28C88E0DF6C0C40F7704EDD11D7E09C32AA3244C1526A1400D8D40991285C6D42C387CD6795D98D676DD64D0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojapPp7P/VpAh4an7Jfy1IUg== X-Mailru-Sender: 3B9A0136629DC912F4AABCEFC589C81EEA82B2E1021433E53E818DC4061170B0046DA7111CBAD36DAD07DD1419AC565FA614486B47F28B67C5E079CCF3B0523AED31B7EB2E253A9E112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 06/30] test: disable PUC Lua tests confused by -v output X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Ostanevich via Tarantool-patches Reply-To: Sergey Ostanevich Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Any follow-up ticket for this? Mention it in the commit message, and = it's LGTM. Sergos > On 26 Mar 2021, at 10:42, Sergey Kaplun wrote: >=20 > Version and status are printed in stdout instead stderr since > LuaJIT-2.0.0-beta11 (as it is not an error message). > See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735 > (Print version and JIT status to stdout, not stderr.). > This behavior is the same as in Lua 5.2. >=20 > This patch disables tests confused by unexpected -v output to stdout. >=20 > Relates to tarantool/tarantool#5687 > Part of tarantool/tarantool#5845 > Part of tarantool/tarantool#4473 > --- > test/PUC-Lua-5.1-tests/main.lua | 28 ++++++++++++++++++++-------- > 1 file changed, 20 insertions(+), 8 deletions(-) >=20 > diff --git a/test/PUC-Lua-5.1-tests/main.lua = b/test/PUC-Lua-5.1-tests/main.lua > index c11a576..56f56a0 100644 > --- a/test/PUC-Lua-5.1-tests/main.lua > +++ b/test/PUC-Lua-5.1-tests/main.lua > @@ -103,26 +103,37 @@ prepfile[[ > RUN("lua - < %s > %s", prog, out) > checkout("1\tnil\n") >=20 > +-- Version and status are printed in stdout instead stderr since > +-- LuaJIT-2.0.0-beta11 (as it is not an error message). > +-- See commit 0bd1a66f2f055211ef55834ccebca3b82d03c735 > +-- (Print version and JIT status to stdout, not stderr.). > +-- This behavior is the same as in Lua 5.2. > +-- In Lua 5.2 this feature was introduced via commit > +-- 9e7de9473c65baee1f567852a778f2d33a47ea83. > +-- See also https://github.com/tarantool/tarantool/issues/5687. > prepfile[[ > =3D (6*2-6) -- =3D=3D=3D > a > =3D 10 > print(a) > =3D a]] > -RUN([[lua -e"_PROMPT=3D'' _PROMPT2=3D''" -i < %s > %s]], prog, out) > -checkout("6\n10\n10\n\n") > +-- FIXME: Behavior is different for LuaJIT. See the comment above. > +-- RUN([[lua -e"_PROMPT=3D'' _PROMPT2=3D''" -i < %s > %s]], prog, = out) > +-- checkout("6\n10\n10\n\n") >=20 > prepfile("a =3D [[b\nc\nd\ne]]\n=3Da") > print(prog) > -RUN([[lua -e"_PROMPT=3D'' _PROMPT2=3D''" -i < %s > %s]], prog, out) > -checkout("b\nc\nd\ne\n\n") > +-- FIXME: Behavior is different for LuaJIT. See the comment above. > +-- RUN([[lua -e"_PROMPT=3D'' _PROMPT2=3D''" -i < %s > %s]], prog, = out) > +-- checkout("b\nc\nd\ne\n\n") >=20 > prompt =3D "alo" > prepfile[[ -- > a =3D 2 > ]] > -RUN([[lua "-e_PROMPT=3D'%s'" -i < %s > %s]], prompt, prog, out) > -checkout(string.rep(prompt, 3).."\n") > +-- FIXME: Behavior is different for LuaJIT. See the comment above. > +-- RUN([[lua "-e_PROMPT=3D'%s'" -i < %s > %s]], prompt, prog, out) > +-- checkout(string.rep(prompt, 3).."\n") >=20 > s =3D [=3D[ -- > function f ( x ) > @@ -140,8 +151,9 @@ assert( a =3D=3D b ) > =3Df( 11 ) ]=3D] > s =3D string.gsub(s, ' ', '\n\n') > prepfile(s) > -RUN([[lua -e"_PROMPT=3D'' _PROMPT2=3D''" -i < %s > %s]], prog, out) > -checkout("11\n1\t2\n\n") > +-- FIXME: Behavior is different for LuaJIT. See the comment above. > +-- RUN([[lua -e"_PROMPT=3D'' _PROMPT2=3D''" -i < %s > %s]], prog, = out) > +-- checkout("11\n1\t2\n\n") >=20 > prepfile[[#comment in 1st line without \n at the end]] > RUN("lua %s", prog) > --=20 > 2.31.0 >=20