From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 09B0D2B114
	for <tarantool-patches@freelists.org>; Mon, 15 Apr 2019 10:06:36 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id ovW92PsgBgss for <tarantool-patches@freelists.org>;
	Mon, 15 Apr 2019 10:06:35 -0400 (EDT)
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B69C22B10C
	for <tarantool-patches@freelists.org>; Mon, 15 Apr 2019 10:06:35 -0400 (EDT)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: [tarantool-patches] Re: [PATCH v1 1/3] sql: remove mayAbort field from struct Parse
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <c61874aac0070e167320fd1ed86b4af012219b2e.1555072183.git.imeevma@gmail.com>
Date: Mon, 15 Apr 2019 17:06:32 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <C89F4290-D9FA-4CF0-9FB1-285A1E208D63@tarantool.org>
References: <cover.1555072183.git.imeevma@gmail.com>
 <c61874aac0070e167320fd1ed86b4af012219b2e.1555072183.git.imeevma@gmail.com>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>



> On 12 Apr 2019, at 15:34, imeevma@tarantool.org wrote:
>=20
> Currently, the mayAbort field is used only in one place in debug
> mode and is not used in non-debug mode. This patch removes this
> field.

Could you be more specific when pointing out the reason of removal?
What was the feature you are removing and why it can be removed?
Argument like =E2=80=98it is used only in debug mode=E2=80=99 doesn=E2=80=99=
t seem to be
convincing enough.

> Part of #4074

Code involved in this patch doesn=E2=80=99t throw any errors,
so why it is a part of diag replacement?

I guess this code clean-up can be OK, but we must
be sure that this functionality can=E2=80=99t be applied to our
SQL implementation.